The build fails with No system or bundled fmt was found, we have to merge #101251 first and add fmt to deps.

@samuelgrf ah right, we only added support for system fmt 3 days ago: PCSX2/pcsx2#3838, before that we ended up using a baked in one. This derivation should still work with the baked in fmt though: No system fmt was found. Using bundled

The build failed before that because I forgot to add myself to maintainers-list.nix

Ah, seems like you have sandboxing disabled, the build otherwise fails because there's no network connection.
fetchFromGitHub doesn't fetch submodules by default.

Sorry for the delay, @samuelgrf I realized I tested on a path that already had submodules, which the fetchGithub one did not have, so that was unrelated to the sandboxing.

As a matter of fact the repository already had submodules so it's a wonder this went unnoticed for so long.

I went ahead and rebased + updated the fetch git. This should be good to merge for now, until we switch to a builtin system fmt.

Hi @GovanifY,

Thanks for the changes. Great to have an upstream maintainer on board 👍 Just two more things that can be fixed with one interactive rebase (git rebase -i):

• rename the commit to pcsx2: unstable-2020-10-10 -> unstable-2020-11-13, following our contribution guide
• change the order of the commits, you must first be added to the maintainers list, else the first commit leaves a broken nixpkgs tree

Thanks for the guidance @hrdinka , this should now be good to go!

Great, I will merge it when ofborg has finished!

@GovanifY #101251 was just merged, I think it'd be best add the change to this pr instead of opening a new one afterwards.

@samuelgrf this should take care of that, although pcsx2 currently requires a specific fmt version. I'll think about removing this version check and simply ensuring major versions sync on upstream later.

Anything else I need to do before merging this?

@samuelgrf As explained in the comments of your review I kept the fetchSubmodules since the current repository already used submodules in some cases and we might introduce more in the future.
Is there anything else I need to change before merging this?

Great that we got this done, thanks to everyone 👍