Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timescaledb: Move unfree library to separate package to fix the license #103507

Closed
wants to merge 2 commits into from
Closed

timescaledb: Move unfree library to separate package to fix the license #103507

wants to merge 2 commits into from

Conversation

chkno
Copy link
Member

@chkno chkno commented Nov 11, 2020

Motivation for this change

Fix the timescaledb license.
Make the Free/Libre/Open Source timescaledb build available.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    43361488 → 4300513
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

timescaledb maintainers: @volth @marsam

@ofborg ofborg bot requested review from marsam and volth November 11, 2020 22:39
@chkno
timescaledb: Move unfree library to separate package timescaledb-tsl
c33389b 
Timescaledb has had the wrong license.  It should have been unfree.

Timescaledb can build in 'apache-licensed-code-only' mode to get
apache-licensed build artifacts.  But the nixpkgs build before this commit
has been building the unfree code and labeling it as apache-licensed.

This commit fixes the situation by
  * Renaming "timescaledb" to "timescaledb-tsl" and fixing its license.
  * Changing "timescaledb" to be the free (Apache-licensed) build, which
    I think is what most users want.

I.e., if this commit breaks you, switch from "timescaledb" to
"timescaledb-tsl" and update your allowUnfreePredicate to allow it.

A timescaledb nixos test has been added to verify that the core timescaledb
functionality — the PostgreSQL plugin — works with the apache-licensed
free build.
@chkno
Copy link
Member Author

chkno commented Nov 12, 2020

Please, make the choice explicit.
Defaulting to any one of the choices is counter-intuitive
One might expect unfree version by default having nixpkgs.config.allowUnfree = true

Done. Thanks!

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103507 run on x86_64-linux 1

1 package blacklisted:
  • tests.nixos-functions.nixos-test
2 packages built:
  • postgresqlPackages.timescaledb (postgresql11Packages.timescaledb)
  • postgresqlPackages.timescaledb-tsl (postgresql11Packages.timescaledb-tsl)

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103507 run on x86_64-darwin 1

2 packages built:
  • postgresqlPackages.timescaledb (postgresql11Packages.timescaledb)
  • postgresqlPackages.timescaledb-tsl (postgresql11Packages.timescaledb-tsl)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice thoughtpolice is a code owner

@marsam marsam Awaiting requested review from marsam marsam is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chkno @SuperSandro2000