Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open-vm-tools: 11.1.5 -> 11.2.0 #103466

Merged
merged 1 commit into from Nov 25, 2020
Merged

open-vm-tools: 11.1.5 -> 11.2.0 #103466

merged 1 commit into from Nov 25, 2020

Conversation

CheariX
Copy link
Contributor

@CheariX CheariX commented Nov 11, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The two patch files could be removed since they are now include in the original code. The remaining change is a simple version bump.

@CheariX
Copy link
Contributor Author

CheariX commented Nov 17, 2020 •
edited

Any update on this? /cc @joamaki

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103466 run on x86_64-linux 1

2 packages built:
  • open-vm-tools
  • open-vm-tools-headless

@SuperSandro2000 SuperSandro2000 merged commit 3d4e98e into NixOS:master Nov 25, 2020
@CheariX CheariX deleted the open-vm-tools-11.2.0 branch November 25, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CheariX @SuperSandro2000