Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hsetroot: 1.0.2 -> 1.0.5 #103465

Merged
merged 1 commit into from Nov 15, 2020
Merged

hsetroot: 1.0.2 -> 1.0.5 #103465

merged 1 commit into from Nov 15, 2020

Conversation

SCOTT-HAMILTON
Copy link
Contributor

Motivation for this change

#103457

Things done

Upgraded hsetroot to 1.0.5

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from henrytill November 11, 2020 16:36
@srhb
Copy link
Contributor

srhb commented Nov 11, 2020

Builds and runs for me. Some notes on the source change: Plenty of repos already use this version according to repology, including FreeBSD ports, Arch, etc. LGTM.

@jonringer jonringer changed the title hsetroot: Update 1.0.2 → 1.0.5 hsetroot: 1.0.2 → 1.0.5 Nov 11, 2020
jonringer
jonringer reviewed Nov 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To comply with CONTRIBUTING.md please have the commit message name be of the format

<pkg-name>: <subject-line>

for more examples, please look at https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes

in your case, the commit message should be:

hsetroot: 1.0.2 -> 1.0.5

otherwise LGTM

@AndersonTorres AndersonTorres changed the title hsetroot: 1.0.2 → 1.0.5 hsetroot: 1.0.2 -> 1.0.5 Nov 12, 2020
@AndersonTorres
Copy link
Member

AndersonTorres commented Nov 12, 2020 •
edited

Please, don't use fancy special characters as "→" in commit messages.

Use -> instead.

hsetroot: 1.0.2 -> 1.0.5

@SCOTT-HAMILTON
Copy link
Contributor Author

Sorry, I have this bad habit to use some fancy characters as those are easily accessible with my keyboard layout.

AndersonTorres
AndersonTorres suggested changes Nov 13, 2020
View reviewed changes
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amend the commit message.

AndersonTorres
AndersonTorres suggested changes Nov 13, 2020
View reviewed changes
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word "Update" in the commit message is redundant. Drop it.

hsetrooot: 1.0.2 -> 1.0.5

@picnoir
Copy link
Member

picnoir commented Nov 15, 2020

Result of nixpkgs-review pr 103465 1

1 package built:
  • hsetroot

@picnoir picnoir merged commit 4898f2b into NixOS:master Nov 15, 2020
@picnoir
Copy link
Member

picnoir commented Nov 15, 2020

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@AndersonTorres AndersonTorres AndersonTorres requested changes

@srhb srhb srhb approved these changes

@picnoir picnoir picnoir approved these changes

@henrytill henrytill Awaiting requested review from henrytill

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SCOTT-HAMILTON @srhb @AndersonTorres @picnoir @jonringer