Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] gitAndTools.gh: 1.2.0 -> 1.2.1 #103514

Merged
merged 1 commit into from Nov 11, 2020
Merged

[20.09] gitAndTools.gh: 1.2.0 -> 1.2.1 #103514

merged 1 commit into from Nov 11, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Nov 11, 2020

https://github.com/cli/cli/releases/tag/v1.2.1
(cherry picked from commit 1e53f7e)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq zowoq changed the title gitAndTools.gh: 1.2.0 -> 1.2.1 [20.09] gitAndTools.gh: 1.2.0 -> 1.2.1 Nov 11, 2020
@ofborg ofborg bot requested a review from kalbasit November 11, 2020 23:35
@jonringer
Copy link
Contributor

jonringer commented Nov 11, 2020 •
edited

no breaking changes. LGTM

why draft?

@zowoq
Copy link
Contributor Author

zowoq commented Nov 11, 2020

why draft?

#103512 (comment)

@zowoq zowoq marked this pull request as ready for review November 11, 2020 23:42
@zowoq zowoq merged commit d3634f4 into NixOS:release-20.09 Nov 11, 2020
@zowoq zowoq deleted the gh2009 branch November 11, 2020 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @jonringer