Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitAndTools.gh: 1.2.0 -> 1.2.1 #103512

Merged
merged 1 commit into from Nov 11, 2020
Merged

gitAndTools.gh: 1.2.0 -> 1.2.1 #103512

merged 1 commit into from Nov 11, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Nov 11, 2020

https://github.com/cli/cli/releases/tag/v1.2.1

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 103512 1

1 package built:
  • gitAndTools.gh

@jonringer jonringer merged commit 1e53f7e into NixOS:master Nov 11, 2020
@zowoq
Copy link
Contributor Author

zowoq commented Nov 11, 2020

@jonringer I opened a PR so this would go though ofborg. I don't understand why you would merge this so quickly?

@zowoq zowoq deleted the gh branch November 11, 2020 23:10
@ofborg ofborg bot requested a review from kalbasit November 11, 2020 23:28
@zowoq zowoq mentioned this pull request Nov 11, 2020
Merged
10 tasks
@jonringer
Copy link
Contributor

the diff was pretty "vanilla" version bump.

If there was any evaluation errors, it should have been caught during a build.

@zowoq
Copy link
Contributor Author

zowoq commented Nov 12, 2020

Considering it's more effort to open a PR then it is to just push to master I'd appreciate it if the PR was allowed to finish CI.

@jonringer
Copy link
Contributor

noted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @jonringer