Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netatalk: remove glibc input #103498

Merged
merged 1 commit into from Nov 11, 2020
Merged

netatalk: remove glibc input #103498

merged 1 commit into from Nov 11, 2020

Conversation

Kloenk
Copy link
Member

@Kloenk Kloenk commented Nov 11, 2020

Motivation for this change

netatalk failes to build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Kloenk
Copy link
Member Author

Kloenk commented Nov 11, 2020

netatalk service starts, could not yet test if it also works as a timemachine.

jonringer
jonringer approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 103498 1

1 package built:
  • netatalk

@jonringer jonringer merged commit db0db5c into NixOS:master Nov 11, 2020
@Kloenk Kloenk deleted the netatalk branch November 11, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kloenk @jonringer