Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pykdl: fix build with latest SIP #104647

Merged
merged 1 commit into from Dec 6, 2020
Merged

pythonPackages.pykdl: fix build with latest SIP #104647

merged 1 commit into from Dec 6, 2020

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Backport orocos/orocos_kinematics_dynamics#270 to fix the build with the latest version of SIP. Only needed to build the Python bindings, not orocos-kdl.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @jonringer

@lopsided98
Copy link
Contributor Author

@ofborg build python3Packages.pykdl

@lopsided98
pythonPackages.pykdl: fix build with latest SIP
053c8d8 
Backport an upstream patch to fix the build. Only needed to build the Python
bindings, not orocos-kdl.
@marsam marsam merged commit d0751da into NixOS:master Dec 6, 2020
@lopsided98 lopsided98 deleted the pykdl-fix branch December 6, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lopsided98 @SuperSandro2000 @marsam