Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rakudo: 2020.10 -> 2020.11 #104644

Merged
merged 3 commits into from Nov 24, 2020
Merged

rakudo: 2020.10 -> 2020.11 #104644

merged 3 commits into from Nov 24, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Nov 23, 2020 •
edited

Motivation for this change

https://github.com/rakudo/rakudo/blob/2020.11/docs/ChangeLog

dependencies:
nqp: 2020.10 -> 2020.11
moarvm: 2020.10 -> 2020.11

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Tested OK on linux x64 and darwin x64

Result of nixpkgs-review pr 104644 1

4 packages built:
  • moarvm
  • nqp
  • rakudo
  • zef

@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 104644 1

4 packages built:
  • moarvm
  • nqp
  • rakudo
  • zef

@aanderse
Copy link
Member

Sorry @stigtsp I don't have any perl6 to maintain, no one here ever got into it... so I'm not qualified to review this. But it's you... so I implicitly approve 😉

@stigtsp
Copy link
Member Author

stigtsp commented Nov 24, 2020

@aanderse I'll go ahead and self-merge it then. :)

@stigtsp stigtsp merged commit 13b0a81 into NixOS:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrthra vrthra Awaiting requested review from vrthra

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@aanderse aanderse Awaiting requested review from aanderse

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stigtsp @RaghavSood @aanderse