Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xteddy: fix src #104657

Merged
merged 1 commit into from Nov 23, 2020
Merged

xteddy: fix src #104657

merged 1 commit into from Nov 23, 2020

Conversation

RaghavSood
Copy link
Member

Motivation for this change

#104048

Leftover from #65796, but looks like whatever we were doing to require a manual escape is no longer being done

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104657 run on x86_64-linux 1

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104657 run on x86_64-linux 1

@RaghavSood
Copy link
Member Author

Result of nixpkgs-review pr 104657 1

@RaghavSood
Copy link
Member Author

I think nixpkgs-review sees this as a noop, since it complains when I try to explicitly build xteddy

[nix-shell:~/nixpkgs/nixpkgs]$ nixpkgs-review pr --post-result 104657 -p xteddy
The following packages specified with `-p` are not rebuild by the pull request
xteddy

@prusnak prusnak merged commit 7a0a539 into NixOS:master Nov 23, 2020
@RaghavSood RaghavSood deleted the xteddy/src branch November 23, 2020 09:26
@xaverdh xaverdh mentioned this pull request Nov 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RaghavSood @SuperSandro2000 @prusnak