New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dropbox: 83.4.152->111.3.447 #104653
dropbox: 83.4.152->111.3.447 #104653
Conversation
Result of 3 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a particular reason why there is no hash here?
@iliaaz https://www.dropbox.com/download?plat=lnx.x86_64 redirects to https://clientupdates.dropboxstatic.com/dbx-releng/client/dropbox-lnx.x86_64-110.4.458.tar.gz - are you sure that 111.3.447 is not some kind of beta release? how did you arrive at this version? |
@SuperSandro2000 I'm happy to generate one but I didn't see a hash from Dropbox itself and there wasn't one previously included. @prusnak After installation, the client updates itself to the most recent version so I used the version number that my client had settled upon at the time of committing. It's possible that it's already out of date but I can't think of any reason it would have loaded a beta release. That being said, I just followed the prior approach of bumping the version in order to solve the issue but I'm not clear what the virtue is of specifying the version number rather than relying on the redirect as you did. That would seem like a better long term solution to me. |
I think it would be a good idea to not rely on the redirect and use the version directly if it is not short lived and use a hash like usually. |
So the download mechanism here isn't the normal kind, where at build time in the build sandbox it uses fetchUrl or one of it's derivatives. It uses the URL at runtime as part of the first run and curls the installer. This is a pretty standard version bump similar to many before, and since it's running in an FSH environment none of the usual nix guarentees are present. I don't think it's necessary, but a check could be added to the bash runScript if people feel strongly about it. |
Result of 3 packages built:
|
Motivation for this change
Upon setting up Dropbox, after authentication the site responds with an error: "You're using an old version of Dropbox. Please download the latest version at www.dropbox.com/downloading". Updating the installer version solves this.
Error message:
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)