Fix GHC bootstrap in pkgsMusl and include patch for binutils/16177 #103183

expipiplus1 · 2020-11-09T06:50:27Z

Motivation for this change

This allows one to cross compile statically linked Haskell programs for armv7

Fixes #85924 using Ben's patch from there. A similar patch should probably be applied to ghc8102-binary.

Fixes https://sourceware.org/bugzilla/show_bug.cgi?id=16177 by applying the patch mentioned there.

Although there was some talk about the efficacy of the binutils patch (https://sourceware.org/bugzilla/show_bug.cgi?id=16177#c9 and expipiplus1/nixpkgs@14efdb2) the resulting binary seems to run without issue on the target platform. Jessica's patch there caused ld to fail linking some programs.

It would be good if there was some resolution to the discussion on the binutils ticket, however this does seem to be an improvement over the broken state of things at the moment.

Obviously this would require rebuilding everything Haskell, and everything on armv7.

Things done

expipiplus1 · 2020-11-09T07:09:00Z

@ofborg build pkgsMusl.haskellPackages.hello

cdepillabout · 2020-11-09T08:49:26Z

cc @Ericson2314 as maintainer for binutils

dasJ · 2020-11-09T10:31:21Z

Mass rebuild so open this against staging, please

expipiplus1 · 2020-11-09T11:10:45Z

Oops, changed the target branch in github and the whole world got requested for reviews, sorry!

dasJ · 2020-11-09T11:12:13Z

@expipiplus1 Don't worry about it, that's just what happens 🤷

expipiplus1 · 2020-11-18T07:14:23Z

If I revert the gdb change then pkgsMusl.haskellPackages.hello builds fine, obviously this update shouldn't be reverted but it's nice to know that this change should enable pkgsMusl.haskellPackages.hello to work once gdb is working again.

nh2

I added two requests to add comments, sounds great otherwise.

pkgs/development/compilers/ghc/8.6.5-binary.nix

pkgs/development/tools/misc/binutils/default.nix

expipiplus1 · 2020-11-26T01:45:25Z

@nh2 I've added the comments as suggested

Also, while doing this I realize that this patch will break the i686 build! I've added some small amount of complexity to only use ncurses6 on x86_64.

nh2

Also, while doing this I realize that this patch will break the i686 build! I've added some small amount of complexity to only use ncurses6 on x86_64.

Just to understand, why is that? Does ncurses6 not work on i686?

expipiplus1 · 2020-11-28T12:08:05Z

It doesn't compile with the changes as before for i686, I guess because it's still using the deb9 version which is linked with ncurses5. There's no fedora27 version for i686.

nh2 · 2020-11-28T12:12:17Z

It doesn't compile with the changes as before for i686, I guess because it's still using the deb9 version which is linked with ncurses5. There's no fedora27 version for i686.

@expipiplus1 Ah, please add that as a comment as well -- "upstream does not provide a version" is a good justification.

@bgamari Do you think there should be a fedora27 version for i686, or should this stay with ncurses5?

expipiplus1 · 2020-11-28T12:17:49Z

Is there even an i686 release of fedora27?

x86_64-linux Ben Gamari's patch from NixOS#85924. Fixes NixOS#85924, allowing one to bootstrap GHC in `pkgsMusl` `nix-build -A pkgsMusl.haskellPackages.hello` succeeds with this patch.

@Ericson2314

…d=16177 This bug was preventing one compiling Haskell programs from `pkgsMusl` for armv7. `nix-build --argstr crossSystem "armv7l-linux" -A pkgsMusl.haskellPackages.hello` succeeds with this patch. The patch is Nick Clifton's one, rebased by @Ericson2314 here https://sourceware.org/bugzilla/show_bug.cgi?id=16177#c6 Although there was some talk about the efficacy of the binutils patch (https://sourceware.org/bugzilla/show_bug.cgi?id=16177#c9) the resulting binary seems to run without issue on the target platform. Jessica's patch there caused ld to fail linking some programs. Nick's proposed patch has worked well in my testing so far (a Haskell project of some small complexity cross compiled with musl to armv7).

expipiplus1 · 2020-11-28T12:19:16Z

@nh2, done

nh2 · 2020-11-28T12:21:45Z

Is there even an i686 release of fedora27?

I think they dropped kernel support with fedora31, but I'm not sure I get the whole picture there: https://fedoramagazine.org/in-fedora-31-32-bit-i686-is-86ed/

nh2 · 2020-11-28T12:25:51Z

@cdepillabout Good to go? The comment you requested has been added. I'm not quite sure if all your questsions from #103183 (comment) are addressed.

cdepillabout

This looks good, thanks for fleshing out the comments!

talw · 2020-12-09T04:02:42Z

@expipiplus1 @Ericson2314

Indeed it is. Cython being used + gdb being target sensative + no splicing black magic has gotten here. I'll make an issue: #104135.

If I revert the gdb change then pkgsMusl.haskellPackages.hello builds fine, obviously this update shouldn't be reverted but it's nice to know that this change should enable pkgsMusl.haskellPackages.hello to work once gdb is working again.

First of all, thank you for the PRs!

I still seem to fail compiling statically due to gdb, whether with the earliest revision containing both PRs 15b3bc33064eeb0cba743cad585c829b6694669c or with the latest revision of nixos-unstable

EDIT: By both PRs, I mean this one, and #104201

Configuring in ./gdb
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../../opcodes -I. -I../../opcodes -I../bfd -I../../opcodes/../include -I../../opcodes/../bfd -I./../intl -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Wstack-usage=262144 -g -O2 -MT disassemble.lo -MD -MP -MF .deps/disassemble.Tpo -c -DARCH_all ../../opcodes/disassemble.c -o disassemble.o
mkdir -p -- ./libctf
Configuring in ./libctf
/nix/store/nz8dyqljf2xwacml7jivafpqqajh15jj-binutils-2.31.1/bin/ld: ax-ipa.o: in function `ax_printf(unsigned long, unsigned long, char const*, int, unsigned long*) [clone .isra.0]':
/build/gdb-10.1/_build/gdbserver/../../gdbserver/ax.cc:928: undefined reference to `libintl_gettext'
/nix/store/nz8dyqljf2xwacml7jivafpqqajh15jj-binutils-2.31.1/bin/ld: /build/gdb-10.1/_build/gdbserver/../../gdbserver/ax.cc:837: undefined reference to `libintl_gettext'
/nix/store/nz8dyqljf2xwacml7jivafpqqajh15jj-binutils-2.31.1/bin/ld: /build/gdb-10.1/_build/gdbserver/../../gdbserver/ax.cc:889: undefined reference to `libintl_gettext'
/nix/store/nz8dyqljf2xwacml7jivafpqqajh15jj-binutils-2.31.1/bin/ld: ax-ipa.o: in function `gdb_eval_agent_expr(eval_agent_expr_context*, agent_expr*, unsigned long*)':
/build/gdb-10.1/_build/gdbserver/../../gdbserver/ax.cc:1334: undefined reference to `libintl_gettext'
/nix/store/nz8dyqljf2xwacml7jivafpqqajh15jj-binutils-2.31.1/bin/ld: gdbsupport/common-utils-ipa.o: in function `xstrvprintf(char const*, __va_list_tag*)':
/build/gdb-10.1/_build/gdbserver/../../gdbserver/../gdbsupport/common-utils.cc:57: undefined reference to `libintl_gettext'
/nix/store/nz8dyqljf2xwacml7jivafpqqajh15jj-binutils-2.31.1/bin/ld: gdbsupport/common-utils-ipa.o:/build/gdb-10.1/_build/gdbserver/../../gdbserver/../gdbsupport/common-utils.cc:69: more undefined references to `libintl_gettext' follow
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:389: libinproctrace.so] Error 1

(...non-error lines...)

make[2]: Leaving directory '/build/gdb-10.1/_build/gdbserver'
make[1]: *** [Makefile:9365: all-gdbserver] Error 2

(...non-error lines...)

make: *** [Makefile:854: all] Error 2
builder for '/nix/store/lay3ilkzal9qsr2k9nbyxm38x1p5cd8k-gdb-10.1.drv' failed with exit code 2
building '/nix/store/v66vfzmg640vgljbq3w61xsyjn1blaqp-cmake-3.19.1.drv'...
cannot build derivation '/nix/store/cbi55fccyxivc6g1nrkh029r4yzdjwfx-python3.8-Cython-0.29.21.drv': 1 dependencies couldn't be built

Is it the same problem? Or is it a different problem?

Ericson2314 · 2020-12-19T16:09:03Z

@talw that looks different, can you make a separate issue if this still exists?

Ericson2314 · 2020-12-19T16:20:26Z

@matthewbauer should we backport this?

talw · 2020-12-21T01:29:16Z

@Ericson2314

I see. I guess it is something different.
I was pulled off temporarily from working on the project where I stumbled upon this case.
But once I get back to it, I will try again with the latest revision at that time, and if it will still happen I shall make an issue for it.

Thanks!

nh2 · 2020-12-21T14:52:44Z

I am using static-haskell-nix which has a survey.nix that overrides a bunch of stuff that results in a gdb that fails to compile.

@talw If you can tell me how to reproduce (best even directly with a nix-build invocation to build gdb from it), I can try and help fix it.

talw · 2020-12-22T01:13:15Z

I am using static-haskell-nix which has a survey.nix that overrides a bunch of stuff that results in a gdb that fails to compile.

@talw If you can tell me how to reproduce (best even directly with a nix-build invocation to build gdb from it), I can try and help fix it.

Thanks @nh2

For reference here is the message I wrote and deleted shortly after (to which you replied):

@talw that looks different, can you make a separate issue if this still exists?

@Ericson2314

I looked at it today, and it looks like it is different as gdb's derivations are different.
Comparing them with nix-diff there were changes going all the way back to curl, zlib and friends. I am using static-haskell-nix which has a survey.nix that overrides a bunch of stuff that results in a gdb that fails to compile. My issue is to be in that repository. Unless I am misguided about the usage of survey.nix

What I realized shortly after is that while the gdb is different and fails to compile, even without
survey.nix's overrides, the vanilla pkgsMusl.gdb fails to compile due to the same problem and on the
revision that includes the 2 PRs that I imagined would fix the gdb issue (perhaps they are unrelated after all?).

The PRs are #104201 and this one #103183

The revision I chose is simply the earliest one to contain both PRs. To reproduce:

$ nix-build --show-trace --no-out-link -E "(import (fetchTarball \"https://github.com/NixOS/nixpkgs/archive/15b3bc33064eeb0cba743cad585c829b6694669c.tar.gz\") {}).pkgsMusl.gdb"

...abbreviated...

/nix/store/zkpjbbicsqa36sg6jb7fcg5qlahcx2na-binutils-2.31.1/bin/ld: ax-ipa.o: in function `ax_printf(unsigned long, unsigned long, char const*, int, unsigned long*) [clone .isra.0]':
/build/gdb-10.1/_build/gdbserver/../../gdbserver/ax.cc:928: undefined reference to `libintl_gettext'
/nix/store/zkpjbbicsqa36sg6jb7fcg5qlahcx2na-binutils-2.31.1/bin/ld: /build/gdb-10.1/_build/gdbserver/../../gdbserver/ax.cc:837: undefined reference to `libintl_gettext'
/nix/store/zkpjbbicsqa36sg6jb7fcg5qlahcx2na-binutils-2.31.1/bin/ld: /build/gdb-10.1/_build/gdbserver/../../gdbserver/ax.cc:889: undefined reference to `libintl_gettext'
/nix/store/zkpjbbicsqa36sg6jb7fcg5qlahcx2na-binutils-2.31.1/bin/ld: ax-ipa.o: in function `gdb_eval_agent_expr(eval_agent_expr_context*, agent_expr*, unsigned long*)':
/build/gdb-10.1/_build/gdbserver/../../gdbserver/ax.cc:1334: undefined reference to `libintl_gettext'
/nix/store/zkpjbbicsqa36sg6jb7fcg5qlahcx2na-binutils-2.31.1/bin/ld: gdbsupport/common-utils-ipa.o: in function `xstrvprintf(char const*, __va_list_tag*)':
/build/gdb-10.1/_build/gdbserver/../../gdbserver/../gdbsupport/common-utils.cc:57: undefined reference to `libintl_gettext'
/nix/store/zkpjbbicsqa36sg6jb7fcg5qlahcx2na-binutils-2.31.1/bin/ld: gdbsupport/common-utils-ipa.o:/build/gdb-10.1/_build/gdbserver/../../gdbserver/../gdbsupport/common-utils.cc:69: more undefined references to `libintl_gettext' follow
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:389: libinproctrace.so] Error 1

...abbreviated...

make[2]: Leaving directory '/build/gdb-10.1/_build/gdbserver'
make[1]: *** [Makefile:9365: all-gdbserver] Error 2

...abbreviated...

make: *** [Makefile:854: all] Error 2
builder for '/nix/store/9ly1l78ggcd6nlhs1c81ilw6x83zc2py-gdb-10.1.drv' failed with exit code 2
error: build of '/nix/store/9ly1l78ggcd6nlhs1c81ilw6x83zc2py-gdb-10.1.drv' failed

expipiplus1 requested a review from cdepillabout as a code owner November 9, 2020 06:50

ofborg bot added 6.topic: haskell 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ labels Nov 9, 2020

expipiplus1 changed the base branch from master to staging November 9, 2020 11:09

expipiplus1 requested review from edolstra, Ericson2314, FRidh, jonringer, kalbasit, matthewbauer, Mic92, mmahut, teto, WilliButz and zowoq as code owners November 9, 2020 11:09

expipiplus1 force-pushed the joe-haskell-cross-2 branch from 14efdb2 to fceffbe Compare November 9, 2020 11:10

zowoq removed their request for review November 15, 2020 00:42

Mic92 removed request for edolstra, FRidh, jonringer, kalbasit and Mic92 November 15, 2020 03:09

nh2 approved these changes Nov 25, 2020

View reviewed changes

pkgs/development/compilers/ghc/8.6.5-binary.nix Show resolved Hide resolved

pkgs/development/tools/misc/binutils/default.nix Show resolved Hide resolved

expipiplus1 force-pushed the joe-haskell-cross-2 branch from 9bc9132 to b70bf82 Compare November 26, 2020 01:44

ofborg bot added 10.rebuild-darwin: 0 and removed 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ labels Nov 26, 2020

nh2 approved these changes Nov 28, 2020

View reviewed changes

expipiplus1 added 2 commits November 28, 2020 20:19

ghc865-binary: Use binary distribution which links against ncurses6 for

15b3bc3

x86_64-linux Ben Gamari's patch from NixOS#85924. Fixes NixOS#85924, allowing one to bootstrap GHC in `pkgsMusl` `nix-build -A pkgsMusl.haskellPackages.hello` succeeds with this patch.

expipiplus1 force-pushed the joe-haskell-cross-2 branch from b70bf82 to b3640e0 Compare November 28, 2020 12:19

cdepillabout approved these changes Nov 28, 2020

View reviewed changes

FRidh merged commit e239c8b into NixOS:staging Nov 28, 2020

expipiplus1 deleted the joe-haskell-cross-2 branch November 28, 2020 13:29

Gaelan mentioned this pull request Dec 22, 2020

Can't build linux-headers on armv6l #107386

Closed

nomeata mentioned this pull request Apr 7, 2021

GHC-8.6.5 bootstrap binary installation segfault on musl #118731

Closed

nh2 mentioned this pull request Jul 4, 2021

GHC does not build with musl (ZuriHac 2021 edition) #129247

Closed

Majiir mentioned this pull request Nov 8, 2022

Some cross-compiled armv7l programs can't get stdout and stderr, causing segfaults #143791

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix GHC bootstrap in pkgsMusl and include patch for binutils/16177 #103183

Fix GHC bootstrap in pkgsMusl and include patch for binutils/16177 #103183

expipiplus1 commented Nov 9, 2020 •

edited

expipiplus1 commented Nov 9, 2020

cdepillabout commented Nov 9, 2020

dasJ commented Nov 9, 2020

expipiplus1 commented Nov 9, 2020

dasJ commented Nov 9, 2020

expipiplus1 commented Nov 18, 2020

nh2 left a comment

expipiplus1 commented Nov 26, 2020

nh2 left a comment

expipiplus1 commented Nov 28, 2020

nh2 commented Nov 28, 2020

expipiplus1 commented Nov 28, 2020

expipiplus1 commented Nov 28, 2020

nh2 commented Nov 28, 2020

nh2 commented Nov 28, 2020

cdepillabout left a comment

talw commented Dec 9, 2020 •

edited

Ericson2314 commented Dec 19, 2020

Ericson2314 commented Dec 19, 2020

talw commented Dec 21, 2020

nh2 commented Dec 21, 2020

talw commented Dec 22, 2020 •

edited

Fix GHC bootstrap in pkgsMusl and include patch for binutils/16177 #103183

Fix GHC bootstrap in pkgsMusl and include patch for binutils/16177 #103183

Conversation

expipiplus1 commented Nov 9, 2020 • edited

Motivation for this change

Things done

expipiplus1 commented Nov 9, 2020

cdepillabout commented Nov 9, 2020

dasJ commented Nov 9, 2020

expipiplus1 commented Nov 9, 2020

dasJ commented Nov 9, 2020

expipiplus1 commented Nov 18, 2020

nh2 left a comment

Choose a reason for hiding this comment

expipiplus1 commented Nov 26, 2020

nh2 left a comment

Choose a reason for hiding this comment

expipiplus1 commented Nov 28, 2020

nh2 commented Nov 28, 2020

expipiplus1 commented Nov 28, 2020

expipiplus1 commented Nov 28, 2020

nh2 commented Nov 28, 2020

nh2 commented Nov 28, 2020

cdepillabout left a comment

Choose a reason for hiding this comment

talw commented Dec 9, 2020 • edited

Ericson2314 commented Dec 19, 2020

Ericson2314 commented Dec 19, 2020

talw commented Dec 21, 2020

nh2 commented Dec 21, 2020

talw commented Dec 22, 2020 • edited

expipiplus1 commented Nov 9, 2020 •

edited

talw commented Dec 9, 2020 •

edited

talw commented Dec 22, 2020 •

edited