Skip to content

docker: Fix broken pipe on docker layer creation #103200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2020
Merged

docker: Fix broken pipe on docker layer creation #103200

merged 1 commit into from
Nov 9, 2020
+2 −2

Conversation

mickours
Copy link
Contributor

@mickours mickours commented Nov 9, 2020

Add -p to the tee command to avoid exiting on breaking pipe due to tarsum finishing before tar while creating docker layers.

(cherry picked from commit 24c5059)

Backport of #101403 into 20.09

@mickours
docker: Fix broken pipe on docker layer creation

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
6c52efb 
Add `-p` to the `tee` command to avoid exiting on breaking pipe due to
tarsum finishing before tar which creating docker layers.

(cherry picked from commit 24c5059)
@mickours mickours requested a review from roberth November 9, 2020 11:14
@ofborg ofborg bot added 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 9, 2020
roberth
roberth approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, waiting for ofborg

@mickours
Copy link
Contributor Author

mickours commented Nov 9, 2020

All is green!

@roberth
Copy link
Member

roberth commented Nov 9, 2020

Thanks!

@roberth roberth merged commit 96052f3 into NixOS:release-20.09 Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberth roberth

Assignees
No one assigned
Labels
8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mickours @roberth