Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libreoffice: Use --without-system-libnumbertext instead of --disable-libnumbertext #103185

Merged
merged 1 commit into from Dec 7, 2020
Merged

libreoffice: Use --without-system-libnumbertext instead of --disable-libnumbertext #103185

merged 1 commit into from Dec 7, 2020

Conversation

ilmari-lauhakangas
Copy link
Contributor

Option to disable libnumbertext was removed with
https://git.libreoffice.org/core/commit/c392ecfa734731194c366e869a3c2475c53dc867
It will affect 7.1.

@ofborg build libreoffice-still

@7c6f434c
Copy link
Member

7c6f434c commented Nov 9, 2020

If you prefixed your commit with the package names, as advised, ofborg would actually build these packages automatically.

@ilmari-lauhakangas
Copy link
Contributor Author

Should the download.nix files be updated as well?

@7c6f434c
Copy link
Member

7c6f434c commented Nov 9, 2020

Is there any change for it, though?

It is generated indiscriminately from the hopefully-full list of downloads the build system knows about.

@ilmari-lauhakangas
Copy link
Contributor Author

Is there any change for it, though?

It is generated indiscriminately from the hopefully-full list of downloads the build system knows about.

libnumbertext was disabled, so now it would be downloaded as external. I was wondering, if I need to add it immediately, but maybe you will add it upon the next version increment.

@7c6f434c
Copy link
Member

7c6f434c commented Nov 9, 2020 via email

@peterhoeg peterhoeg changed the title Use --without-system-libnumbertext instead of --disable-libnumbertext libreoffice: Use --without-system-libnumbertext instead of --disable-libnumbertext Nov 15, 2020
@ilmari-lauhakangas
Copy link
Contributor Author

Is there a reason for not merging this yet? As mentioned in Tor's commit message, using --disable-libnumbertext results in a buggy build: "disabling it broke the ordinal page (etc) numbering feature". So would be nice to get this into 7.0.

@7c6f434c 7c6f434c merged commit 83cbad9 into NixOS:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants