Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bind: fix cross-compilation #103181

Merged
merged 1 commit into from Nov 19, 2020
Merged

bind: fix cross-compilation #103181

merged 1 commit into from Nov 19, 2020

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Upstream accidentally broke cross-compilation. It has been fixed but not released yet, so we need to temporarily add the patch here.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @peti @globin

@veprbl veprbl added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Nov 9, 2020
@ofborg ofborg bot requested review from peti and globin November 9, 2020 03:06
@lopsided98
bind: fix cross-compilation
0e9f925 
Upstream accidently broke cross-compilation. It has been fixed but not released
yet, so we temporarily add the patch here.
@FRidh FRidh merged commit 82a9f23 into NixOS:master Nov 19, 2020
@lopsided98 lopsided98 deleted the bind-cross branch November 20, 2020 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@peti peti Awaiting requested review from peti

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lopsided98 @SuperSandro2000 @veprbl @FRidh