Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dogdns: install shell completions and man page #103192

Closed
wants to merge 1 commit into from
Closed

dogdns: install shell completions and man page #103192

wants to merge 1 commit into from

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Nov 9, 2020

Motivation for this change

Install the upstream shell completions and manual page.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from bbigras November 9, 2020 09:46
@teto
Copy link
Member

teto commented Nov 9, 2020

Have you checked the closure size ? bringing pandoc in is huge. As much as I love having manpages, maybe it should be gated behing a withManpage flag.

@danieldk danieldk mentioned this pull request Nov 9, 2020
Open
@danieldk
Copy link
Contributor Author

danieldk commented Nov 9, 2020

Have you checked the closure size ? bringing pandoc in is huge. As much as I love having manpages, maybe it should be gated behing a withManpage flag.

Good point. I think not having a man page is a suboptimal experience, so I opened an upstream issue to ask if they could include the generated man page in the repository:

ogham/dog#3

@danieldk
Copy link
Contributor Author

danieldk commented Nov 9, 2020

@bbigras we should probably do likewise for nuspell.

@evanjs
Copy link
Member

evanjs commented Nov 22, 2020

Looks like we just need the man page, now?
Seems like @marsam added the completions with f4e1112 (part of #103131).

@danieldk danieldk closed this Nov 23, 2020
@danieldk danieldk deleted the dogdns-shell-man branch November 23, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbigras bbigras Awaiting requested review from bbigras

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @teto @evanjs