Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fend: init at 0.1.9 #103179

Merged
merged 1 commit into from Nov 9, 2020
Merged

fend: init at 0.1.9 #103179

merged 1 commit into from Nov 9, 2020

Conversation

djanatyn
Copy link
Contributor

@djanatyn djanatyn commented Nov 9, 2020

Motivation for this change

fend is an arbitrary-precision calculator that supports a wide array of units.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103179 run on x86_64-darwin 1

1 package built:
  • fend

@AndersonTorres
Copy link
Member

LGTM, LGTBorg.

@AndersonTorres AndersonTorres merged commit c08c8a5 into NixOS:master Nov 9, 2020
AndersonTorres
AndersonTorres reviewed Nov 9, 2020
View reviewed changes
Copy link
Member

@AndersonTorres AndersonTorres left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next: ping fend developers to include Nixpkgs in their "distros including fend" badge!

Are you interested, @djanatyn ? :)

@djanatyn djanatyn mentioned this pull request Nov 11, 2020
Merged
@djanatyn
Copy link
Contributor Author

@AndersonTorres Very interested! I reached out: printfn/fend#41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres AndersonTorres left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@djanatyn @SuperSandro2000 @AndersonTorres