Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] moodle: 3.9.1 -> 3.9.3 #103191

Merged
merged 1 commit into from Nov 10, 2020
Merged

[20.09] moodle: 3.9.1 -> 3.9.3 #103191

merged 1 commit into from Nov 10, 2020

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

Upstream update
Release notes: http://docs.moodle.org/dev/Moodle_3.9.3_release_notes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from aanderse November 9, 2020 09:18
@aanderse
Copy link
Member

You should target this against master first, then we can cherry pick a backport.

@freezeboy
Copy link
Contributor Author

I opened two different PRs but this one is not really a backport of the other as I stick to 3.9 branch, whereas on master, I move to 3.10

@aanderse
Copy link
Member

Ah makes sense now. Thanks!

@aanderse aanderse merged commit 3bcb8ab into NixOS:release-20.09 Nov 10, 2020
@freezeboy freezeboy deleted the update-stable-moodle branch November 10, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse Awaiting requested review from aanderse

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@freezeboy @aanderse