-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
applet.interface.uart: convert to nmigen #228
Conversation
a741360
to
5b50d7e
Compare
I'm aware of the failed test, but can't replicate it here... When running all tests, I see the following ("same" error, different test).
When running the test specifically, I see:
I have also seen errors such as below, when my code is bad. I was considering raising an issue, though not sure if it's Yosys, nMigen or Glasgow.
|
It is not your responsibility to fix the build error. (As in, I'll look into it, but not necessarily soon.) |
Ok, thanks. The gateware and applet work, I've had to tweak things in the tests for the |
Okay, so the error is:
This comes from ABC, so ultimately this is a bug to be filed against Yosys. Is your Yosys a very recent build from git? If not, that's probably why you don't see it. Try upgrading it, or use the CI configuration file to use YoWASP on your machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, not sure why tests are failing...
It seems that the shift register was being truncated to 8-bits regardless of the requested word size, since the `data_bits` attribute was introduced in 0f497e4.
My fault, I added a missing |
Thanks! |
Addresses
interface.uart
item from #150.