Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/plasma5: Fix when running without aliases #103196

Merged
merged 1 commit into from Nov 10, 2020
Merged

nixos/plasma5: Fix when running without aliases #103196

merged 1 commit into from Nov 10, 2020

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Nov 9, 2020

Motivation for this change

It breaks my eval (backports incoming)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dasJ dasJ requested a review from ajs124 November 9, 2020 10:10
@dasJ dasJ added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 9, 2020
@dasJ
Copy link
Member Author

dasJ commented Nov 9, 2020

@GrahamcOfBorg test plasma5

doronbehar
doronbehar approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are too many with expr; in that file (see this), but at least this doesn't make things worse.

@ajs124 ajs124 merged commit fd950b9 into NixOS:master Nov 10, 2020
@ajs124 ajs124 deleted the fix/plasma5-noaliases branch November 10, 2020 15:59
@dasJ dasJ mentioned this pull request Nov 10, 2020
Merged
@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

@ajs124 ajs124 Awaiting requested review from ajs124

@FRidh FRidh Awaiting requested review from FRidh

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: qt/kde 8.has: module (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dasJ @doronbehar @ajs124 @erictapen