Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moodle: 3.9.2 -> 3.10.0 #103190

Merged
merged 1 commit into from Nov 10, 2020
Merged

moodle: 3.9.2 -> 3.10.0 #103190

merged 1 commit into from Nov 10, 2020

Conversation

freezeboy
Copy link
Contributor

@freezeboy freezeboy commented Nov 9, 2020

Motivation for this change

New release
Release notes: http://docs.moodle.org/dev/Moodle_3.10_release_notes

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Comment on lines 5 to 6
stableVersion = #builtins.substring 0 2 (builtins.replaceStrings ["."] [""] version);
lib.concatStrings (lib.take 2 (lib.splitVersion version));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stableVersion = #builtins.substring 0 2 (builtins.replaceStrings ["."] [""] version);
lib.concatStrings (lib.take 2 (lib.splitVersion version));
stableVersion = lib.concatStrings (lib.take 2 (lib.splitVersion version));

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops will fixup

@aanderse aanderse merged commit 3fcfdb9 into NixOS:master Nov 10, 2020
@freezeboy freezeboy deleted the update-moodle branch November 10, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants