Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I am writing some nix expressions to patch some Nintendo GameCube images.
Wiimm's ISO Tools are helpful for this, and what I normally use.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)I tried a few new things with this package that I wasn't confident around:
Setting
sourceRoot
Everything that needs to be built is under
project/
. I saw that some other packages setsourceRoot
.Am I doing this correctly?
Disabling Hardening
This package doesn't build unless we disable some hardening around format strings.
No Tags
The GitHub repository does not have tags, so I added the
rev
directly. The version is from this commit:/usr/bin/env ...
ScriptsI'm fixing this with
sed
, using an approach I saw inpkgs/shells/xonsh/default.nix
.