Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[staging] openblas: fix seg fault on some architectures #103379

Closed
wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 11, 2020

Motivation for this change

got tired of seeing:

builder for '/nix/store/y222lb4h1pd8rdawnwrydixk7iwsrig0-python3.9-numpy-1.19.4.drv' failed with exit code 139; last 10 log lines:
    File "/nix/store/lqndcw0by4f8r23mzbj5sdwj4mzwcmy2-python3.9-pytest-5.4.3/lib/python3.9/site-packages/_pytest/main.py", line 191 in wrap_session
    File "/nix/store/lqndcw0by4f8r23mzbj5sdwj4mzwcmy2-python3.9-pytest-5.4.3/lib/python3.9/site-packages/_pytest/main.py", line 240 in pytest_cmdline_main
    File "/nix/store/6k3k52ziq3hnfspm27vw8xrk6ymgxjgl-python3.9-pluggy-0.13.1/lib/python3.9/site-packages/pluggy/callers.py", line 187 in _multicall
    File "/nix/store/6k3k52ziq3hnfspm27vw8xrk6ymgxjgl-python3.9-pluggy-0.13.1/lib/python3.9/site-packages/pluggy/manager.py", line 84 in <lambda>
    File "/nix/store/6k3k52ziq3hnfspm27vw8xrk6ymgxjgl-python3.9-pluggy-0.13.1/lib/python3.9/site-packages/pluggy/manager.py", line 93 in _hookexec
    File "/nix/store/6k3k52ziq3hnfspm27vw8xrk6ymgxjgl-python3.9-pluggy-0.13.1/lib/python3.9/site-packages/pluggy/hooks.py", line 286 in __call__
    File "/nix/store/lqndcw0by4f8r23mzbj5sdwj4mzwcmy2-python3.9-pytest-5.4.3/lib/python3.9/site-packages/_pytest/config/__init__.py", line 124 in main
    File "/nix/store/ciql00608lqcfysm8b5a9zl945qvn1kv-python3.9-numpy-1.19.4/lib/python3.9/site-packages/numpy/_pytesttester.py", line 206 in __call__
    File "<string>", line 1 in <module>
  /nix/store/77983lbcimy5h6rqhfq6hvvif4ngmsak-stdenv-linux/setup: line 1303:  3449 Segmentation fault      (core dumped) /nix/store/pylx4vzz5kf0x64bf8cx164l5hd02vgn-python3-3.9.0/bin/python3.9 -c 'import numpy; numpy.test("fast", verbose=10)'

when doing reviews. So I did git bisect to pinpoint the issue, located OpenMathLib/OpenBLAS#2970 (comment)

upstream PR: OpenMathLib/OpenBLAS#2982

related: #103360 #101780 (comment)

But, I'm able to build numpy again with tests:

= 10883 passed, 78 skipped, 108 deselected, 21 xfailed, 1 warning in 122.57s (0:02:02) =
/build/numpy-1.19.4
pythonCatchConflictsPhase
pythonRemoveBinBytecodePhase
pythonImportsCheckPhase
Executing pythonImportsCheckPhase
pytestcachePhase
/nix/store/15l44v85rl5ichmbbyjg0701k04hx7dq-python3.8-numpy-1.19.4
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer changed the title openblas: fix seg fault on some architectures [staging] openblas: fix seg fault on some architectures Nov 11, 2020
@ofborg ofborg bot requested a review from ttuegel November 11, 2020 02:08
@jonringer
Copy link
Contributor Author

closing in favor of #104061

@jonringer jonringer closed this Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant