Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.dispatch: 0.4.1 → 0.5.0; ocamlPackages.webmachine: 0.6.2 → 0.7.0 #103403

Merged
merged 1 commit into from Nov 18, 2020
Merged

ocamlPackages.dispatch: 0.4.1 → 0.5.0; ocamlPackages.webmachine: 0.6.2 → 0.7.0 #103403

merged 1 commit into from Nov 18, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Nov 11, 2020

Motivation for this change

Use Dune2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
ocamlPackages.dispatch: 0.4.1 → 0.5.0
8819f4f 
ocamlPackages.webmachine: 0.6.2 → 0.7.0
sternenseemann
sternenseemann approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@sternenseemann sternenseemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, reverse dependencies build fine on x86_64 NixOS

@sternenseemann
Copy link
Member

@GrahamcOfBorg build ocamlPackages.irmin-unix ocamlPackages.dispatch ocamlPackages.webmachine

@vbgl vbgl merged commit 597e774 into NixOS:master Nov 18, 2020
@vbgl vbgl deleted the ocaml-dispatch-0.5.0 branch November 18, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann sternenseemann approved these changes

Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vbgl @sternenseemann