pythonPackages.qutip: init at 4.5.2 #103412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Does not use OpenMP by default * May be overly conservative in disabling python versions older than 3.5 * Note that build time is a bit long, in part due to tests. It might be preferable to disable these in the future.
* Overridden `buildPhase` to build with openmp support * As this does not appear to work with the Pypi version, which lacks certain .cpp source files, `fetchPypi` has been replaced with `fetchGitHub`. * The correct tests have been added, but disabled, as they add a considerable amount of time after an already quite long build phase.
|
Result of 2 packages built:
|
|
Result of 2 packages failed to build:
|
jonringer
reviewed
Dec 28, 2020
There was a problem hiding this comment.
Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the fix-up commits.
git rebase -i is a powerful command which achieves this, I created a small video demonstrating it's use here. A more indepth text tutorial can be found here
| ${python.interpreter} setup.py --with-openmp bdist_wheel | ||
| ''; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
please leave a comment saying why tests werent ran
Comment on lines
+46
to
+48
| buildPhase = '' | ||
| ${python.interpreter} setup.py --with-openmp bdist_wheel | ||
| ''; |
There was a problem hiding this comment.
Suggested change
| buildPhase = '' | |
| ${python.interpreter} setup.py --with-openmp bdist_wheel | |
| ''; | |
| setupPyGlobalFlags = "--with-openmp"; |
SuperSandro2000
requested changes
Dec 28, 2020
Comment on lines
+1
to
+14
| { stdenv | ||
| , python | ||
| , buildPythonPackage | ||
| , pythonOlder | ||
| , fetchFromGitHub | ||
| , setuptoolsBuildHook | ||
| , gcc | ||
| , hypothesis | ||
| , numpy | ||
| , scipy | ||
| , matplotlib | ||
| , cython | ||
| , pytest | ||
| }: |
There was a problem hiding this comment.
Suggested change
| { stdenv | |
| , python | |
| , buildPythonPackage | |
| , pythonOlder | |
| , fetchFromGitHub | |
| , setuptoolsBuildHook | |
| , gcc | |
| , hypothesis | |
| , numpy | |
| , scipy | |
| , matplotlib | |
| , cython | |
| , pytest | |
| }: | |
| { stdenv | |
| , python | |
| , buildPythonPackage | |
| , pythonOlder | |
| , fetchFromGitHub | |
| , setuptoolsBuildHook | |
| , hypothesis | |
| , numpy | |
| , scipy | |
| , matplotlib | |
| , cython | |
| , openmp | |
| , sysctl | |
| }: |
| --replace "numpy>=1.12" "numpy" \ | ||
| --replace "scipy>=1.0" "scipy" | ||
| ''; | ||
|
|
There was a problem hiding this comment.
Suggested change
| nativeBuildInputs = [ setuptoolsBuildHook ]; | |
| buildInputs = stdenv.lib.optionals stdenv.isDarwin [ openmp ]; | |
Comment on lines
+41
to
+42
|
|
||
| nativeBuildInputs = [ numpy scipy cython pytest setuptoolsBuildHook ]; |
There was a problem hiding this comment.
Suggested change
| nativeBuildInputs = [ numpy scipy cython pytest setuptoolsBuildHook ]; |
Comment on lines
+49
to
+50
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
Suggested change
| doCheck = false; | |
| doCheck = false; |
Tests fail one darwin and linux.
|
|
||
| doCheck = false; | ||
|
|
||
| checkInputs = [ hypothesis ]; |
There was a problem hiding this comment.
Suggested change
| checkInputs = [ hypothesis ]; | |
| checkInputs = [ hypothesis sysctl ]; |
| @@ -6116,6 +6116,8 @@ in { | |||
|
|
|||
| queuelib = callPackage ../development/python-modules/queuelib { }; | |||
|
|
|||
| qutip = callPackage ../development/python-modules/qutip { }; | |||
There was a problem hiding this comment.
Suggested change
| qutip = callPackage ../development/python-modules/qutip { }; | |
| qutip = callPackage ../development/python-modules/qutip { | |
| inherit (pkgs.llvmPackages) openmp; | |
| }; |
|
to allow tests: |
|
@mcncm ping |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
12 tasks
|
Closing this, as a newer version of the package is provided by #144102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preferable to disable these in the future.
Motivation for this change
This is a fairly popular quantum simulation package that it would be nice to have easy access to.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"[ ] Tested execution of all binary files (usually in(N/A)./result/bin/)nix-shell -p 'python$X.withPackages (ps: [ ps.qutip ])', forX={36,37,38}, and imported the module in a repl of the respective Python version.nix path-info -Sbefore and after)