Skip to content

SDL2: fix cmake interface includes for SDL2::SDL2 #103438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2020
Merged

SDL2: fix cmake interface includes for SDL2::SDL2 #103438

merged 1 commit into from
Nov 27, 2020
+27 −7

Conversation

cpages
Copy link
Contributor

@cpages cpages commented Nov 11, 2020

Fixes #103346. The environment var for finding the cmake companion libs
headers was missing from the SDL2::SDL2 target, it only worked when
using SDL2_INCLUDE_DIRS.

Things done
  • [ x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [ x] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@cpages
SDL2: fix cmake interface includes for SDL2::SDL2

Verified

This commit was signed with the committer’s verified signature.
prusnak Pavol Rusnak
GPG key ID: 91F3B339B9A02A3D
Verified
Learn about vigilant mode
ba5b8aa 
Fixes NixOS#103346. The environment var for finding the cmake companion libs
headers was missing from the SDL2::SDL2 target, it only worked when
using SDL2_INCLUDE_DIRS.
@cpages cpages merged commit fbd0a85 into NixOS:staging Nov 27, 2020
@cpages cpages deleted the sdl2_incdirs branch January 16, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
Staging
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cpages