Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnetCorePackages.{aspnetcore,net,sdk}_5_0: init / update #103429

Merged
merged 4 commits into from Nov 11, 2020
Merged

dotnetCorePackages.{aspnetcore,net,sdk}_5_0: init / update #103429

merged 4 commits into from Nov 11, 2020

Conversation

felschr
Copy link
Member

@felschr felschr commented Nov 11, 2020 •
edited

Motivation for this change

.NET 5.0 has been released.
Supersedes #101018.

Instead of using netcore_5_0 for the runtime I initialised it using net_5_0 seeing that it's called .NET instead of .NET Core now. I'm open to different naming, though.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@felschr
Copy link
Member Author

felschr commented Nov 11, 2020

@jonringer, you might want to take a look at this.

@jonringer
Copy link
Contributor

@jonringer, you might want to take a look at this.

you're right, I do

jonringer
jonringer approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 103429 1

3 packages built:
  • dotnet-sdk_5 (dotnetCorePackages.sdk_5_0)
  • dotnetCorePackages.aspnetcore_5_0
  • dotnetCorePackages.net_5_0

@jonringer jonringer merged commit a94cc8d into NixOS:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: documentation 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@felschr @jonringer