Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome3.mutter334: Use full sysprof #103400

Merged
merged 1 commit into from
Nov 11, 2020
Merged

gnome3.mutter334: Use full sysprof #103400

merged 1 commit into from
Nov 11, 2020
+2 −2

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Nov 11, 2020 •
edited
Loading

Motivation for this change

Commit 56b9441 (#101528) incorrectly switched mutter and mutter334 from full sysprof to libsysprof-capture, causing channel-blocking build failures:

https://hydra.nixos.org/build/129977355 (mutter)
https://hydra.nixos.org/build/130019098 (mutter334)

Commit 752773e (#103142) reverted only the mutter part. This reverts the mutter334 part.

This is blocking nixos-unstable via the via the pantheon test.

Cc @jtojnar @hedning

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@andersk
gnome3.mutter334: Use full sysprof
49bd665 
Commit 56b9441 (NixOS#101528) incorrectly
switched mutter and mutter334 from full sysprof to libsysprof-capture,
causing channel-blocking build failures:

https://hydra.nixos.org/build/129977355 (mutter)
https://hydra.nixos.org/build/130019098 (mutter334)

Commit 752773e (NixOS#103142) reverted only
the mutter part.  This reverts the mutter334 part.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk andersk requested a review from jtojnar November 11, 2020 05:29
@andersk andersk added 0.kind: regression Something that worked before working no longer 1.severity: channel blocker Blocks a channel 11.by: nixpkgs-member 6.topic: GNOME GNOME desktop environment and its underlying platform labels Nov 11, 2020
This was referenced Nov 11, 2020
Merged
Merged
@ofborg ofborg bot requested a review from worldofpeace November 11, 2020 05:40
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Nov 11, 2020
@hedning hedning merged commit 7fb6d5e into NixOS:master Nov 11, 2020
@hedning
Copy link
Contributor

hedning commented Nov 11, 2020

Thanks, managed to forget about mutter334.

@andersk andersk deleted the mutter334 branch November 11, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar

@worldofpeace worldofpeace

Assignees
No one assigned
Labels
0.kind: regression Something that worked before working no longer 1.severity: channel blocker Blocks a channel 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 11.by: nixpkgs-member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andersk @hedning