Add a WPT test to verify the mouse click count in infrastructure/ #26480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 11, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2515882
branch
from
f0fce92
to
e8b1bb9
Compare
We should have a WPT test to verify the mouse click count, such as double click and triple click. For the click count is greater than 3, we should increase it when the OS is Windows and Mac, reset to 1 otherwise. Also reset the mouse click count, if the mouse moves to a different locations. Bug: 1119679 Change-Id: I755c1f49a470598391440802e2ad62817a958777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515882 Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#830279}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2515882
branch
from
e8b1bb9
to
7399bd4
Compare
|
Looks like this failed on Firefox: https://community-tc.services.mozilla.com/tasks/AKWrpLS4Rz2GK_d-TtW5_A/runs/0/logs/https%3A%2F%2Fcommunity-tc.services.mozilla.com%2Fapi%2Fqueue%2Fv1%2Ftask%2FAKWrpLS4Rz2GK_d-TtW5_A%2Fruns%2F0%2Fartifacts%2Fpublic%252Flogs%252Flive.log#L2298 cc @LanWei22 |
Hexcles
force-pushed
the
chromium-export-cl-2515882
branch
from
325dc6d
to
529a8bd
Compare
|
It's somewhat unclear to me why this is an infrastructure test vs a wdspec test? Also what's the spec basis for the expectations? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should have a WPT test to verify the mouse click count, such as
double click and triple click. For the click count is greater than 3, we
should increase it when the OS is Windows and Mac, reset to 1 otherwise.
Also reset the mouse click count, if the mouse moves to a different
locations.
Bug: 1119679
Change-Id: I755c1f49a470598391440802e2ad62817a958777
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515882
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#830279}