Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.zigpy-zigate: propagate build inputs #105039

Merged
merged 1 commit into from Nov 26, 2020
Merged

python3Packages.zigpy-zigate: propagate build inputs #105039

merged 1 commit into from Nov 26, 2020

Conversation

mvnetbiz
Copy link
Contributor

Motivation for this change

I didn't notice zigpy-zigate didn't have propagatedBuildInputs before. It's other dependencies previously happened to be resolved by its fellow zigpy-* modules, but recent update added a unique dependency on pyusb, causing my home-assistant to fail at loading the component.

Things done

Changed zigpy-zigate to propagate build inputs.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member

Oh yeah, I missed that. Also I'm personally a zigbee2mqtt user :)

@mweinelt mweinelt merged commit de7d93f into NixOS:master Nov 26, 2020
@ofborg ofborg bot requested a review from etu November 26, 2020 14:36
@mvnetbiz mvnetbiz deleted the zigpy-zigate branch November 28, 2020 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@etu etu Awaiting requested review from etu

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvnetbiz @mweinelt