Skip to content

python3Packages.zigpy-zigate: propagate build inputs #105039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2020
Merged

python3Packages.zigpy-zigate: propagate build inputs #105039

merged 1 commit into from
Nov 26, 2020
+1 −1

Conversation

mvnetbiz
Copy link
Contributor

Motivation for this change

I didn't notice zigpy-zigate didn't have propagatedBuildInputs before. It's other dependencies previously happened to be resolved by its fellow zigpy-* modules, but recent update added a unique dependency on pyusb, causing my home-assistant to fail at loading the component.

Things done

Changed zigpy-zigate to propagate build inputs.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@mvnetbiz
python3Packages.zigpy-zigate: propagate build inputs

Verified

This commit was signed with the committer’s verified signature. The key has expired.
vdemeester Vincent Demeester
GPG key ID: 083CC6FD6EB699A3
Expired
Verified
Learn about vigilant mode
0e2730b
@mvnetbiz mvnetbiz requested a review from mweinelt November 26, 2020 14:26
@mweinelt
Copy link
Member

Oh yeah, I missed that. Also I'm personally a zigbee2mqtt user :)

@mweinelt mweinelt merged commit de7d93f into NixOS:master Nov 26, 2020
@ofborg ofborg bot requested a review from etu November 26, 2020 14:36
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 26, 2020
@mvnetbiz mvnetbiz deleted the zigpy-zigate branch November 28, 2020 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt

@FRidh FRidh

@jonringer jonringer

@etu etu

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvnetbiz @mweinelt