Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: 7.3.24 -> 7.3.25, 7.4.12 -> 7.4.13 #105040

Merged
merged 2 commits into from Nov 27, 2020
Merged

php: 7.3.24 -> 7.3.25, 7.4.12 -> 7.4.13 #105040

merged 2 commits into from Nov 27, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Nov 26, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ajs124 ajs124 marked this pull request as ready for review November 26, 2020 14:45
@ajs124 ajs124 requested a review from etu November 26, 2020 14:45
@etu etu requested a review from a team November 26, 2020 19:09
@etu
Copy link
Contributor

etu commented Nov 26, 2020

The commit message for the php74 bumps should begin with php74 instead of php73 :)

@ajs124
Copy link
Member Author

ajs124 commented Nov 26, 2020

oops, fixed.

@etu
Copy link
Contributor

etu commented Nov 26, 2020

@ofborg eval

@etu
Copy link
Contributor

etu commented Nov 27, 2020

Thanks @ajs124 👍

@etu etu merged commit 1d2835c into NixOS:master Nov 27, 2020
@ajs124 ajs124 deleted the upd/php branch November 29, 2020 00:40
@ajs124 ajs124 mentioned this pull request Jan 8, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu Awaiting requested review from etu

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajs124 @etu