Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] postfix: fix "cant find <mysql.h>" when building with "withMySQL = true" #105034

Merged
merged 1 commit into from Nov 26, 2020
Merged

[20.09] postfix: fix "cant find <mysql.h>" when building with "withMySQL = true" #105034

merged 1 commit into from Nov 26, 2020

Conversation

ymarkus
Copy link
Contributor

@ymarkus ymarkus commented Nov 26, 2020

(cherry picked from commit 0e87647)

Motivation for this change

backport #105006 to fix the 20.09 postfix package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ymarkus
postfix: fix "cant find <mysql.h>"
01eb683 
(cherry picked from commit 0e87647)
@ymarkus
Copy link
Contributor Author

ymarkus commented Nov 26, 2020

pinging @mweinelt as he merged the PR into master.

@mweinelt mweinelt merged commit 7f144df into NixOS:release-20.09 Nov 26, 2020
@ymarkus ymarkus deleted the backport-fix-postfixMySQL branch November 26, 2020 14:03
@ymarkus
Copy link
Contributor Author

ymarkus commented Nov 26, 2020

Thanks again!

@mweinelt
Copy link
Member

mweinelt commented Nov 26, 2020 •
edited

No, thank you! I took the change of your pull request and applied it to one of my nur-packages, which had the same issue.

@ymarkus
Copy link
Contributor Author

ymarkus commented Nov 26, 2020

I'm not sure if this is appropriate here, but just a quick question: what's the best way to use this in my configuration.nix until hydra is done with the job in a few days? In an overlay?

@mweinelt
Copy link
Member

Not an expert on overrides, personally I prefer applying the change on top of a local checkout that I reference during nixos-rebuild.

ǹixos-rebuild -I nixpkgs=/path/to/nixpkgs/checkout switch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ymarkus @mweinelt