Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qtox: Fix compilation on darwin #105065

Merged
merged 3 commits into from Dec 9, 2020
Merged

qtox: Fix compilation on darwin #105065

merged 3 commits into from Dec 9, 2020

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change

#105059

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Nov 26, 2020
Merged
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 26, 2020
@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 105065 run on x86_64-linux 1

@ofborg ofborg bot requested review from akaWolf and peterhoeg November 26, 2020 19:42
@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 105065 run on x86_64-darwin 1

73 packages marked as broken and skipped:
  • almanah
  • aravis
  • balsa
  • cq-editor
  • falkon
  • fgallery
  • firefox-esr-78-unwrapped
  • firefox-unwrapped
  • firefoxPackages.firefox
  • firefoxPackages.firefox-esr-78
  • fractal
  • frescobaldi
  • gmic-qt-krita
  • gnome-podcasts
  • gnome-recipes
  • gnome3.nautilus-python
  • gnome3.webkitgtk
  • gnvim
  • gnvim-unwrapped
  • gtkd
  • haskellPackages.reflex-dom
  • haskellPackages.webkit2gtk3-javascriptcore
  • kicad-small
  • kicad-unstable-small
  • liquidsoap
  • luakit
  • mate.atril
  • mate.mate-user-guide
  • mavproxy
  • multibootusb
  • newsflash
  • onboard
  • picard
  • python27Packages.foxdot
  • python27Packages.imantics
  • python27Packages.pyglet
  • python27Packages.pytmx
  • python27Packages.remotecv
  • python27Packages.vidstab
  • python27Packages.wxPython_4_0
  • python37Packages.baselines
  • python37Packages.caffe
  • python37Packages.foxdot
  • python37Packages.gym
  • python37Packages.kicad
  • python37Packages.mask-rcnn
  • python37Packages.optuna
  • python37Packages.pyglet
  • python37Packages.pytmx
  • python37Packages.rl-coach
  • python37Packages.roboschool
  • python37Packages.wxPython_4_0
  • python37Packages.wxPython_4_1
  • python38Packages.caffe
  • python38Packages.foxdot
  • python38Packages.gym
  • python38Packages.kicad
  • python38Packages.mask-rcnn
  • python38Packages.pyglet
  • python38Packages.pytmx
  • python38Packages.roboschool
  • python38Packages.wxPython_4_0
  • python38Packages.wxPython_4_1
  • radiotray-ng
  • rednotebook
  • run-scaled
  • saga
  • setzer
  • surf
  • vuze
  • webkitgtk
  • xulrunner
  • yaxg
73 packages failed to build:
  • anki
  • caffe
  • facedetect
  • ffmpeg-full
  • frei0r
  • ghostwriter
  • gimpPlugins.gmic
  • gmic
  • gmic-qt
  • gst_all_1.gst-editing-services
  • gst_all_1.gst-plugins-bad
  • gst_all_1.gst-rtsp-server
  • handbrake
  • haskellPackages.opencv
  • haskellPackages.opencv-extra
  • hydron
  • hydrus
  • keybase
  • manim
  • mellowplayer
  • mnemosyne
  • mopidy-iris
  • mopidy-local
  • mopidy-mopify
  • mopidy-mpd
  • mopidy-mpris
  • mopidy-musicbox-webclient
  • mopidy-somafm
  • mopidy-soundcloud
  • mopidy-spotify-tunigo
  • mopidy-tunein
  • mopidy-youtube
  • nomacs
  • olive-editor
  • opencv (opencv4)
  • opencv3 (opencv3WithoutCuda)
  • pithos
  • python-qt
  • python27Packages.imutils
  • python27Packages.opencv (python27Packages.opencv4)
  • python27Packages.opencv3
  • python27Packages.pydub
  • python27Packages.pyqtwebengine
  • python37Packages.imagecorruptions
  • python37Packages.imantics
  • python37Packages.imutils
  • python37Packages.opencv3
  • python37Packages.opencv4
  • python37Packages.pydub
  • python37Packages.pyqtwebengine
  • python37Packages.stytra
  • python37Packages.vidstab
  • python38Packages.imagecorruptions
  • python38Packages.imantics
  • python38Packages.imutils
  • python38Packages.opencv3
  • python38Packages.opencv4
  • python38Packages.pydub
  • python38Packages.pyqtwebengine
  • python38Packages.stytra
  • python38Packages.vidstab
  • qsyncthingtray
  • qt5.qtwebengine (qt512.qtwebengine)
  • qt5.qtwebview (qt512.qtwebview)
  • qt514.qtwebengine
  • qt514.qtwebview
  • qt515.qtwebengine
  • qt515.qtwebview
  • qutebrowser
  • sayonara
  • sl1-to-photon
  • termplay
  • webmacs
1 package built:
  • qtox

@SuperSandro2000 SuperSandro2000 force-pushed the qtox-darwin branch 2 times, most recently from 4a88085 to b27032e Compare December 9, 2020 04:20
@SuperSandro2000
qtox: Fix compilation on darwin, remove parallelBuilds, cleanups
b224b4d
@SuperSandro2000
apple_sdk.frameworks.AVFoundation: Add missing CoreMedia
eb1d742 
This fixes apple-framework-AVFoundation/Library/Frameworks/AVFoundation.framework/Headers/AVAsset.h:17:9: fatal error: 'CoreMedia/CMTime.h' file not found
@SuperSandro2000
apple_sdk.frameworks.AVFoundation: Add missing MediaToolbox
848d198 
This fixes:
/nix/store/7ckpydmlah3j86py3c4f27p0fbkxyzfi-apple-framework-AVFoundation/Library/Frameworks/AVFoundation.framework/Headers/AVAudioMix.h:15:9: fatal error: 'MediaToolbox/MTAudioProcessingTap.h' file not found
@SuperSandro2000
Copy link
Member Author

The build failures rise up because qtox was broken before. Some of them are because libmodplug does not build which is supposed to be fixed in #106430. Also there are currently many rebuilds for darwin so I am going to merge this as is and fix the now revealed and already broken packages on master a later time.

@SuperSandro2000 SuperSandro2000 merged commit 2789f6d into NixOS:master Dec 9, 2020
@SuperSandro2000 SuperSandro2000 deleted the qtox-darwin branch December 9, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaWolf akaWolf Awaiting requested review from akaWolf

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 101-500 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@SuperSandro2000