gitAndTools.glab: init at 1.11.1 #105044
Merged
gitAndTools.glab: init at 1.11.1 #105044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 1 package built:
|
pkgs/applications/version-management/git-and-tools/glab/default.nix
Outdated
Show resolved
Hide resolved
|
passed nixpkgs-review. Binary starts. |
teto
approved these changes
Nov 26, 2020
|
Result of 1 package built:
|
kalbasit
reviewed
Nov 27, 2020
| license = licenses.mit; | ||
| homepage = "https://glab.readthedocs.io/"; | ||
| maintainers = with maintainers; [ freezeboy ]; | ||
| platforms = with platforms; unix; |
There was a problem hiding this comment.
Is this necessary? Most Go apps run everywhere Go is supported, and do not require setting platforms because buildGo{Module,Package} has a default value for it.
There was a problem hiding this comment.
Oh didn't notice that default value, should I inherit it or is the buildGo* injecting automatically ?
There was a problem hiding this comment.
Nevermind, figured out
|
Result of nixpkgs-review on aarch64-linux (NixOnDroid): |
doronbehar
approved these changes
Nov 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add another gitlab cli tool
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)