Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8252a44e9661
Choose a base ref
...
head repository: NixOS/nix
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2458270b69b2
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Nov 26, 2020

  1. archive: disable preallocate-contents by default 

    using fallocate() to preallocate files space does more harm than good:
 - breaks compression on btrfs
 - has been called "not the right thing to do" by xfs developers
(because delayed allocation that most filesystems implement leads to smarter
allocation than what the filesystem needs to do if we upfront fallocate files)
    @martinetd
    martinetd committed Nov 26, 2020
    Copy the full SHA
    1fd13d6 View commit details

  2. Merge pull request #4094 from martinetd/btrfs 

    preallocateContents option: disable by default
    @edolstra
    edolstra authored Nov 26, 2020
    Copy the full SHA
    2458270 View commit details
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/libutil/archive.cc
2 changes: 1 addition & 1 deletion src/libutil/archive.cc
View file
Original file line number Diff line number Diff line change
@@ -27,7 +27,7 @@ struct ArchiveSettings : Config
#endif
"use-case-hack",
"Whether to enable a Darwin-specific hack for dealing with file name collisions."};
Setting<bool> preallocateContents{this, true, "preallocate-contents",
Setting<bool> preallocateContents{this, false, "preallocate-contents",
"Whether to preallocate files when writing objects with known size."};
};