Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Darwin support for barcode package #105060

Closed
wants to merge 2 commits into from
Closed

Adding Darwin support for barcode package #105060

wants to merge 2 commits into from

Conversation

Hx0S
Copy link

@Hx0S Hx0S commented Nov 26, 2020 •
edited

Motivation for this change

I needed barcode package on my macOS machine

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 26, 2020
SuperSandro2000
SuperSandro2000 requested changes Nov 26, 2020
View reviewed changes
pkgs/tools/graphics/barcode/default.nix Outdated Show resolved Hide resolved
pkgs/tools/graphics/barcode/default.nix
Comment on lines +22 to +23
configureFlags = stdenv.lib.optional stdenv.isDarwin "ac_cv_func_calloc_0_nonnull=yes" ;
patches = stdenv.lib.optional stdenv.isDarwin [ ./patches/darwin.patch ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this above meta under hardening disabled. The patch should be directly under src.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch should be sent upstream

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move those two lines (configureFlags = ... and patches = ...) above the line meta = .... meta should be the last argument to mkDerivation for readability.

@ofborg ofborg bot requested a review from 7c6f434c November 26, 2020 18:50
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105060 run on x86_64-linux 1

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105060 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • glabels
1 package built:
  • barcode

prusnak
prusnak requested changes Nov 26, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the commit message should be barcode: add darwin support as per https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md

@Hx0S @SuperSandro2000
Update pkgs/tools/graphics/barcode/default.nix
a1e8e52 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000
Copy link
Member

@Hx0S please change the commit message according to prusnak.

@stale
Copy link

stale bot commented Aug 13, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 13, 2021
@wegank wegank mentioned this pull request Jan 2, 2023
Merged
13 tasks
@wegank wegank closed this Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

@taku0 taku0 taku0 left review comments

@prusnak prusnak prusnak requested changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Hx0S @SuperSandro2000 @prusnak @veprbl @taku0 @wegank @Janik-Haag