Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromedriver: Switch to Chromium's upstream-info.json #105054

Merged
merged 1 commit into from Nov 27, 2020
Merged

chromedriver: Switch to Chromium's upstream-info.json #105054

merged 1 commit into from Nov 27, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Nov 26, 2020

This enables automatic updates and fixes #85629.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos primeos mentioned this pull request Nov 26, 2020
Closed
lukegb
lukegb approved these changes Nov 27, 2020
View reviewed changes
Copy link
Contributor

@lukegb lukegb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, other than that nit.

Finagled the upstream-info.json to force it to rewrite all the entries and it output the exact same thing in this commit, so LGTM.

pkgs/applications/networking/browsers/chromium/update.py Outdated Show resolved Hide resolved
alexanderkranga
alexanderkranga approved these changes Nov 27, 2020
View reviewed changes
Copy link

@alexanderkranga alexanderkranga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#85629 (comment)

@primeos primeos force-pushed the chromedriver-automatic-updates branch from 1179b29 to d75b400 Compare November 27, 2020 11:16
@primeos
chromedriver: Switch to Chromium's upstream-info.json
e84103f 
This enables automatic updates and fixes NixOS#85629.
@primeos primeos force-pushed the chromedriver-automatic-updates branch from d75b400 to e84103f Compare November 27, 2020 11:20
@primeos primeos merged commit 6aea53c into NixOS:master Nov 27, 2020
KyleOndy added a commit to KyleOndy/dotfiles that referenced this pull request Nov 28, 2020
@KyleOndy
niv nixpkgs: update c6a8fcd9 -> d26aa329
783c3c8 
## Changelog for nixpkgs:
Commits: [NixOS/nixpkgs@c6a8fcd9...d26aa329](NixOS/nixpkgs@c6a8fcd...d26aa32)

* [`2b0ee787`](NixOS/nixpkgs@2b0ee78) mosquitto: systemd service sandboxing
* [`43b32e6f`](NixOS/nixpkgs@43b32e6) fractal: mark broken on Darwin
* [`57784466`](NixOS/nixpkgs@5778446) bcompare: 4.3.5.24893 -> 4.3.7.25118
* [`921b15ef`](NixOS/nixpkgs@921b15e) python3Packages.nipype: remove Python 2 support (dependency nibabel already unsupported)
* [`f31be2ec`](NixOS/nixpkgs@f31be2e) python3Packages.nipype: avoid use of neurdflib by default since it causes a package collision when rdflib is in the closure
* [`8d8cd890`](NixOS/nixpkgs@8d8cd89) pasystray: ayatana appindicators instead of libappindicator
* [`65c9bb25`](NixOS/nixpkgs@65c9bb2) clipit: enable appindicator support
* [`ec34ce96`](NixOS/nixpkgs@ec34ce9) pyditz: 0.10.3 -> 0.11
* [`39e33a47`](NixOS/nixpkgs@39e33a4) mpvScripts.mpris: Use mpv-unwrapped
* [`c69dd499`](NixOS/nixpkgs@c69dd49) waifu2x-converter-cpp: 5.2.4 -> 5.3.3
* [`ca3dd4b5`](NixOS/nixpkgs@ca3dd4b) waifu2x-converter-cpp: add OpenCL support
* [`41e9a530`](NixOS/nixpkgs@41e9a53) powertop: strip hcitool FSH path
* [`ed93d1de`](NixOS/nixpkgs@ed93d1d) elementary-planner: 2.4.6 -> 2.5.4
* [`adbe903c`](NixOS/nixpkgs@adbe903) jdupes: 1.18.2 -> 1.19.0
* [`58ab512a`](NixOS/nixpkgs@58ab512) libdigidocpp: 3.14.3 -> 3.14.4
* [`6a1a3207`](NixOS/nixpkgs@6a1a320) keepassrpc: 1.8.0 -> 1.14.0
* [`173bf39c`](NixOS/nixpkgs@173bf39) todoist-electron: 1.23.0 -> 1.24.0
* [`59455622`](NixOS/nixpkgs@5945562) todoist-electron: Switch to MIT license
* [`8cfeba2b`](NixOS/nixpkgs@8cfeba2) todoist-electron: Use desktop icon
* [`3d9ee22d`](NixOS/nixpkgs@3d9ee22) wine{Unstable,Staging}: 5.20 -> 5.21
* [`dfcd45de`](NixOS/nixpkgs@dfcd45d) wineStable: 5.0.2 -> 5.0.3
* [`152147a8`](NixOS/nixpkgs@152147a) wine-mono: 4.9.4 -> 5.1.1
* [`22da5d92`](NixOS/nixpkgs@22da5d9) wine{Unstable,Staging}: 5.21 -> 5.22
* [`4d5ab8d9`](NixOS/nixpkgs@4d5ab8d) autofs: fix compilation fail due to libtirpc changes
* [`9144ebaf`](NixOS/nixpkgs@9144eba) wineStable: revert cert-path patch for stable
* [`626f9310`](NixOS/nixpkgs@626f931) wineUnstable: use own set of patches
* [`db17db53`](NixOS/nixpkgs@db17db5) nginx: 1.19.4 -> 1.19.5
* [`587ef348`](NixOS/nixpkgs@587ef34) postgresqlPackages.pg_hll: 2.14 -> 2.15
* [`5183864d`](NixOS/nixpkgs@5183864) linux: explicitly enable RAS
* [`d9d8c8a7`](NixOS/nixpkgs@d9d8c8a) blender: use ffmpeg instead of ffmpeg_3
* [`492f3b80`](NixOS/nixpkgs@492f3b8) blender: fix on darwin
* [`05440fda`](NixOS/nixpkgs@05440fd) shotcut: use qt-5.15, rework
* [`8f46b51e`](NixOS/nixpkgs@8f46b51) ammonite: 2.2.0 -> 2.3.8
* [`1b14ab86`](NixOS/nixpkgs@1b14ab8) _1password-gui: 0.9.4-1 -> 0.9.5-2
* [`b3efb719`](NixOS/nixpkgs@b3efb71) avocode: 4.7.0 -> 4.10.3
* [`92672cff`](NixOS/nixpkgs@92672cf) qmapshack: 1.15.0 → 1.15.1
* [`fcbedf65`](NixOS/nixpkgs@fcbedf6) Revert "nmap: 7.80 -> 7.90"
* [`00afc855`](NixOS/nixpkgs@00afc85) gitter: 4.1.0 -> 5.0.1
* [`63dd41f7`](NixOS/nixpkgs@63dd41f) bombadillo: init at 2.3.3
* [`89f75b02`](NixOS/nixpkgs@89f75b0) geeqie: 1.4.0 -> 1.5.1
* [`706ed34e`](NixOS/nixpkgs@706ed34) containerd: 1.4.1 -> 1.4.2
* [`3ed321df`](NixOS/nixpkgs@3ed321d) z3: enable build on non-x86_64 unix; checked the build on aarch64-linux
* [`06f2fd5f`](NixOS/nixpkgs@06f2fd5) jetbrains: updates
* [`6aea53c3`](NixOS/nixpkgs@6aea53c) chromedriver: Switch to Chromium's upstream-info.json (NixOS/nixpkgs#105054)
* [`abe1271f`](NixOS/nixpkgs@abe1271) perlPackages.Appcpm: init at 0.994
* [`0229bebd`](NixOS/nixpkgs@0229beb) cimg: 2.9.3 -> 2.9.4
* [`3546e475`](NixOS/nixpkgs@3546e47) fondo: 1.3.9 -> 1.3.10
* [`ac3f6009`](NixOS/nixpkgs@ac3f600) pythonPackages.browsermob-proxy: drop insecure python-cryptography transitive dependency; only used for Marionette anyway
* [`0d6bc2f7`](NixOS/nixpkgs@0d6bc2f) broot: 1.0.5 -> 1.0.6
* [`94486021`](NixOS/nixpkgs@9448602) enlightenment.evisum: 0.5.7 -> 0.5.8
* [`64939cff`](NixOS/nixpkgs@64939cf) neomutt: 20201120 -> 20201127
* [`763e8380`](NixOS/nixpkgs@763e838) ephemeral: 6.4.1 -> 7.0.4
* [`34d28198`](NixOS/nixpkgs@34d2819) ammonite: Fix arguments
* [`f98df98d`](NixOS/nixpkgs@f98df98) google-chrome: Remove msteen from the list of maintainers (NixOS/nixpkgs#105152)
* [`eb7d3672`](NixOS/nixpkgs@eb7d367) runLaTeX: rerun at least twice + refactor (NixOS/nixpkgs#104185)
* [`77e367e9`](NixOS/nixpkgs@77e367e) datovka: 4.15.5 -> 4.15.6
* [`09a0f4ca`](NixOS/nixpkgs@09a0f4c) discord-ptb: 0.0.22 -> 0.0.23
* [`df1c8e3f`](NixOS/nixpkgs@df1c8e3) python3Packages.snowflake-connector-python: Fix boto3 replace
* [`08c74a2d`](NixOS/nixpkgs@08c74a2) python3Packages.snowflake-sqlalchemy: Disable running tests
* [`d0f04c7c`](NixOS/nixpkgs@d0f04c7) frostwire-bin: 6.8.7 -> 6.8.8
* [`67d7a671`](NixOS/nixpkgs@67d7a67) tilt: 0.17.11 -> 0.17.12
@KyleOndy KyleOndy mentioned this pull request Nov 28, 2020
Closed
primeos added a commit to primeos/nixpkgs that referenced this pull request Jan 2, 2021
@primeos
chromedriver: Switch to Chromium's upstream-info.json (NixOS#105054)
dbaaeaf 
This enables automatic updates and fixes NixOS#85629.

(cherry picked from commit 6aea53c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukegb lukegb lukegb approved these changes

@alexanderkranga alexanderkranga alexanderkranga approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incompatible chrome and chromedriver
3 participants
@primeos @lukegb @alexanderkranga