Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/lvm2-activation-generator: fix warnings on activation #103876

Merged
merged 1 commit into from Nov 16, 2020
Merged

nixos/lvm2-activation-generator: fix warnings on activation #103876

merged 1 commit into from Nov 16, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 15, 2020 •
edited

Motivation for this change

fixes #103188 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from ajs124 November 15, 2020 07:06
@Mic92 Mic92 mentioned this pull request Nov 15, 2020
Closed
@ajs124
Copy link
Member

ajs124 commented Nov 15, 2020

.text appends if it gets assigned multiple times, right?

If so, is lvm actually happy with this with any of the other options in there?

@Mic92
Copy link
Member Author

Mic92 commented Nov 16, 2020

.text appends if it gets assigned multiple times, right?

If so, is lvm actually happy with this with any of the other options in there?

You can have multiple config {} sections. They get merged without complaints.

@ajs124
Copy link
Member

ajs124 commented Nov 16, 2020

Interesting tooling they got over there…
As you can see from the other things putting things in lvm.conf, they don't even use config {}, which also works.

Well, but then this is probably good to go.

@Mic92 Mic92 merged commit e54cd0e into NixOS:master Nov 16, 2020
@Mic92 Mic92 deleted the lvm-generator-fix branch November 16, 2020 17:37
@Mic92
Copy link
Member Author

Mic92 commented Nov 16, 2020

I suppose we need to backport this?

@aanderse
Copy link
Member

I suppose we need to backport this?

Yes please.

@Mic92
Copy link
Member Author

Mic92 commented Nov 16, 2020

backport: #103983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajs124 ajs124 Awaiting requested review from ajs124

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"lvm2-activation-generator: lvmconfig failed" displayed during boot etc.
3 participants
@Mic92 @ajs124 @aanderse