Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xlife: init at 6.7.5 #103884

Merged
merged 2 commits into from Nov 26, 2020
Merged

xlife: init at 6.7.5 #103884

merged 2 commits into from Nov 26, 2020

Conversation

djanatyn
Copy link
Contributor

Motivation for this change

There are a few different branches of xlife development. This is the 6.7 (2013) branch, documented in the development history on the homepage:

It appears to be the most recent development branch available.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I've also added the hpndSellVariant license that this application uses. I've done the same in a previous PR: #103518

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 23, 2020 •
edited

Fails to build for me:

configuring
configuring with imake: ''
imake -DUseInstalled -I/nix/store/xj92pflviva2kd0frrq6ya40pcnryhgq-imake-1.0.8/lib/X11/config
/nix/store/xj92pflviva2kd0frrq6ya40pcnryhgq-imake-1.0.8/bin/xmkmf: line 53:    13 Aborted                 (core dumped) imake $imake_defines $args

@djanatyn
Copy link
Contributor Author

@SuperSandro2000 I couldn't reproduce this build error.

I wonder if there is an issue in the Imakefile: https://sourceforge.net/p/xlife-cal/xlife/HEAD/tree/trunk/Imakefile

The closest I could find to that error was this Red Hat Bugzilla thread: https://bugzilla.redhat.com/show_bug.cgi?id=1605031

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103884 run on x86_64-linux 1

1 package built:
  • xlife

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103884 run on x86_64-darwin 1

@SuperSandro2000
Copy link
Member

Builds now. No idea why it failed earlier.

@SuperSandro2000 SuperSandro2000 merged commit 97cce32 into NixOS:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais Awaiting requested review from alyssais alyssais is a code owner

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@djanatyn @SuperSandro2000