New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clickhouse: 20.5.2.7 -> 20.11.4.13 #105224
Conversation
It does fail on OfBorg, so likely it would fail when I build it too. I'll see if I can update it in the coming days, I recall it being somewhat painful to update the last time as well, but I do have some beefy machines that can at least build it, so should be possible |
We should probably switch clickhouse to using UNBUNDLED mode instead so we don't have to rebuild e.g. LLVM as part of the clickhouse build... |
I hit
while building this. |
#105286 makes Clickhouse use the system LLVM instead of compiling its own, which at least seemed to make it evaluate on ofBorg. |
There is a patch for the build issue in: ClickHouse/ClickHouse#16859 Until there is a new upstream version, we could apply that patch ourselves |
With diff --git a/pkgs/servers/clickhouse/default.nix b/pkgs/servers/clickhouse/default.nix
index b519d1b4315..2cad2150153 100644
--- a/pkgs/servers/clickhouse/default.nix
+++ b/pkgs/servers/clickhouse/default.nix
@@ -1,4 +1,4 @@
-{ stdenv, fetchFromGitHub, cmake, libtool, lldClang, ninja
+{ stdenv, fetchFromGitHub, fetchpatch, cmake, libtool, lldClang, ninja
, boost, brotli, capnproto, cctz, clang-unwrapped, double-conversion
, icu, jemalloc, libcpuid, libxml2, lld, llvm, lz4, libmysqlclient, openssl, perl
, poco, protobuf, python3, rapidjson, re2, rdkafka, readline, sparsehash, unixODBC
@@ -17,6 +17,13 @@ stdenv.mkDerivation rec {
sha256 = "0c87k0xqwj9sc3xy2f3ngfszgjiz4rzd787bdg6fxp94w1adjhny";
};
+ patches = [
+ (fetchpatch {
+ url = "https://github.com/ClickHouse/ClickHouse/commit/e31753b4db7aa0a72a85757dc11fc403962e30db.patch";
+ sha256 = "12ax02dh9y9k8smkj6v50yfr46iprscbrvd4bb9vfbx8xqgw7grb";
+ })
+ ];
+
nativeBuildInputs = [ cmake libtool lldClang.bintools ninja ];
buildInputs = [
boost brotli capnproto cctz clang-unwrapped double-conversion This builds for me:
|
@schneefux You should be able to You'll also want to rebase on master, since it now has my change to use system LLVM instead of the bundled one, which should make it build (much) faster. I'll rebuild once you've pushed up a new branch :) |
81956b0
to
c2fa0a1
Compare
Result of 1 package failed to build:
|
It still does not build within an hour on my server, so I'm afraid I have to give up and hand it over to @RaghavSood 🙈 |
Result of 1 package failed to build:
|
hrm. Maybe I broke it. |
Clickhouse now needs LLVM10: you'll need to update |
Continuing in #105968 |
Motivation for this change
Updated clickhouse to the latest version.
Building clickhouse takes multiple hours, my machine is not powerful enough so I could not test this change☹️
Can someone help here?
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)