Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smpeg2: 412 -> unstable-2017-10-18 #105216

Merged
merged 1 commit into from Dec 11, 2020
Merged

smpeg2: 412 -> unstable-2017-10-18 #105216

merged 1 commit into from Dec 11, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Nov 28, 2020 •
edited

Motivation for this change
  • rework of Update SDL2_mixer dependencies #70421
  • updated by 1 SVN revision
  • use new format for version
  • drop patch not needed anymore
  • rename gcc6.patch to hufftable-uint_max.patch to make it more obvious what it does
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak changed the base branch from staging to master November 28, 2020 09:13
@prusnak @abbradar
smpeg2: 412 -> unstable-2017-10-18
c2429bb 
drop patch not needed anymore

Co-authored-by: Nikolay Amiantov <ab@fmap.me>
@prusnak prusnak mentioned this pull request Nov 28, 2020
Closed
10 tasks
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 28, 2020 •
edited

Result of nixpkgs-review pr 105216 run on x86_64-linux 1

1 package marked as broken and skipped:
  • frogatto
3 packages failed to build:
  • devilutionx
  • hedgewars
  • worldofgoo
76 packages built:
  • SDL2_mixer
  • Sylk
  • _1oom
  • abbaye-des-morts
  • appimage-run
  • augustus
  • cataclysm-dda
  • cataclysm-dda-git
  • chocolateDoom
  • commandergenius
  • crawlTiles
  • crispyDoom
  • deltachat-electron
  • devdocs-desktop
  • easyrpg-player
  • eduke32
  • electronplayer
  • flare
  • gemrb
  • guile-sdl2
  • haskellPackages.Raincat
  • haskellPackages.nyx-game
  • haskellPackages.piyo
  • haskellPackages.sdl2-mixer
  • instead
  • instead-launcher
  • irccloud
  • ivan
  • joplin-desktop
  • julius
  • keeweb
  • ledger-live-desktop
  • liberal-crime-squad
  • lightspark
  • lunar-client
  • marktext
  • minetime
  • molotov
  • mycrypto
  • notable
  • np2kai
  • nuclear
  • nxengine-evo
  • opendune
  • p3x-onenote
  • pingus
  • plexamp
  • python27Packages.pygame_sdl2
  • python27Packages.pysdl2
  • python27Packages.pytmx
  • python37Packages.pygame_sdl2
  • python37Packages.pysdl2
  • python37Packages.pytmx
  • python38Packages.pygame_sdl2
  • python38Packages.pysdl2
  • python38Packages.pytmx
  • renpy
  • retrofe
  • rocksndiamonds
  • runwayml
  • sfrotz
  • smpeg2
  • ssb-patchwork
  • standardnotes
  • station
  • steam-run-native
  • taisei
  • timeular
  • trackballs
  • tusk
  • ultrastardx
  • unityhub
  • wesnoth (wesnoth-dev)
  • wootility
  • zettlr
  • zulip

Failed builds require source to be downloaded separately.

@SuperSandro2000 SuperSandro2000 merged commit 998653a into NixOS:master Dec 11, 2020
@prusnak prusnak deleted the smpeg2 branch December 11, 2020 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@orivej-nixos orivej-nixos Awaiting requested review from orivej-nixos

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @SuperSandro2000 @Mic92