home-assistant: add allowlist_external_dirs to systemd unit ReadWritePaths #104268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofborg eval |
mweinelt
approved these changes
Nov 28, 2020
|
I noticed test flakyness on my own server too some times. Sometimes a second nixos-rebuild is needed then it works fine. I think there is some kind of race in the home assistant integration tests |
|
Not the nixos tests but the pytests |
|
Yeah, I've reported some of them upstream, but the general message I receive is, that if they work in their CI they don't really want to invest time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Home Assistant has configuration setting
allowlist_external_dirsto grant access to a directory (save security camera footage, etc.), but the service unit file hasProtectSystemenabled, blocking access to this. If the configuration is managed through NixOS, the paths are automatically added, and since the option is declared as a list now you can add paths manually in other cases throughsystemd.services.home-assistant.serviceConfig.ReadWritePaths = [ ... ];Things done
modified nixos/modules/services/misc/home-assistant.nix to add specified paths in
services.home-assistant.config.homeassistant.allowlist_external_dirsto the systemd service's ReadWritePaths.sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)