fetchCargoTarball: support vendoring extra manifests #104281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveej
force-pushed
the
pr/fetchcargotarball-extra-manifests
branch
from
b516955
to
1c2f8f5
Compare
There was a problem hiding this comment.
Can you add some documentation for this? I assume that https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/rust.section.md would be the right place but I am not 100% sure.
This is helpful in a situation where not all crates in the given repository are listed in the toplevel Cargo.toml but are required during the build-process.
steveej
force-pushed
the
pr/fetchcargotarball-extra-manifests
branch
from
1c2f8f5
to
162971c
Compare
|
My use-case for this has ceased. It might still make sense to merge this since it's a feature offered by |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Please add a test case so that we can ensure your feature continues working whenever we refactor the code. |
stale
bot
removed
the
2.status: stale
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
i haven't been using this myself so i won't pursue this PR any longer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is helpful in a situation where not all crates in the given
repository are listed in the toplevel Cargo.toml but are required during
the build-process.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)