Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lambda-delta: init at 0.98.3 #104276

Merged
merged 1 commit into from Dec 2, 2020
Merged

lambda-delta: init at 0.98.3 #104276

merged 1 commit into from Dec 2, 2020

Conversation

siraben
Copy link
Member

@siraben siraben commented Nov 19, 2020

I don't know how to use the software, but it builds.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

IvarWithoutBones
IvarWithoutBones requested changes Nov 20, 2020
View reviewed changes
pkgs/misc/emulators/lambda-delta/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@siraben
Copy link
Member Author

siraben commented Nov 20, 2020

Result of nixpkgs-review pr 104276 1

1 package built:
  • lambda-delta

@siraben
Copy link
Member Author

siraben commented Nov 30, 2020

@SuperSandro2000 Looks good to merge?

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104276 run on x86_64-linux 1

1 package built:
  • lambda-delta

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104276 run on x86_64-darwin 1

1 package built:
  • lambda-delta

@SuperSandro2000 SuperSandro2000 merged commit 85769ec into NixOS:master Dec 2, 2020
@siraben siraben deleted the lambda-delta-init branch December 25, 2021 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvarWithoutBones IvarWithoutBones IvarWithoutBones requested changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siraben @SuperSandro2000 @IvarWithoutBones