cgit: strip debug symbols from cgit.cgi #104246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The debug symbols result in an unneeded runtime dependency on GCC, and properly stripping them shrinks the size of the closure significantly.
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
bjornfor
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The debug symbols result in an unneeded runtime dependency on GCC, and properly stripping them shrinks the size of the closure significantly.
Before:
/nix/store/8w3jvkmbkxd2jh3bg0w9pfhas81x8kd3-cgit-1.2.3 343805152After:
/nix/store/gn64n0w8f7yqrzwwzcg8gi6v638hxfyk-cgit-1.2.3 147108936Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)My primary use case for this is generating Docker images, so that's what I've been testing with.