Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.hakyll: unbreak #104273

Merged
merged 1 commit into from Nov 19, 2020
Merged

haskellPackages.hakyll: unbreak #104273

merged 1 commit into from Nov 19, 2020

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Nov 19, 2020 •
edited

Motivation for this change

Hakyll is currently broken on 20.09. I fixed it by massaging jaspervdj/hakyll@f24c587 and adding it in as a patch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@maralorn
Copy link
Member

@GrahamcOfBorg build haskellPackages.hakyll

@maralorn
Copy link
Member

@vaibhavsagar For future reference: You don‘t need to copy patches like that into nixpkgs. It normally suffices to use pkgs.fetchpatch and github offers various easy possibilities to get an url that returns a valid patch for a commit or pr. There are a lots of examples for this in the haskell configuration-*.nix files.

@maralorn
Copy link
Member

Thanks! Looks good to me.

@maralorn maralorn merged commit 9a8ee55 into NixOS:release-20.09 Nov 19, 2020
@vaibhavsagar
Copy link
Member Author

@maralorn that wouldn't have worked in this case, since the commit includes changes to files that aren't in the released package. Thanks for letting me know though!

@vaibhavsagar vaibhavsagar deleted the unbreak-hakyll branch November 19, 2020 16:38
@maralorn
Copy link
Member

Don‘t underestimate the raw undocumented powers of fetchpatch. It e.g. has includes and excludes lists as optional parameters. It sounds like they could have helped in this context.

@vaibhavsagar vaibhavsagar mentioned this pull request Nov 20, 2020
Merged
10 tasks
@ghost
Copy link

ghost commented Nov 25, 2020

/* hackage-packages.nix is an auto-generated file -- DO NOT EDIT! */

You should remove it from pkgs/development/haskell-modules/configuration-hackage2nix.yaml see #73755

@cdepillabout
Copy link
Member

@gnidorah

#104375 (comment)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/new-ghc-default-version-8-10-2-package-versions-now-from-stackage-nightly/10117/32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout left review comments

@maralorn maralorn maralorn left review comments

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vaibhavsagar @maralorn @cdepillabout @nixos-discourse