Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spdlog: 1.7.0 -> 1.8.1 (fixes BEAR build) #104261

Merged
merged 4 commits into from Nov 20, 2020
Merged

spdlog: 1.7.0 -> 1.8.1 (fixes BEAR build) #104261

merged 4 commits into from Nov 20, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 19, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Nov 19, 2020

fixes build of bear.

@Mic92 Mic92 changed the title spdlog: 1.7.0 -> 1.8.1 spdlog: 1.7.0 -> 1.8.1 (fixes BEAR build) Nov 19, 2020
@ofborg ofborg bot requested a review from obadz November 19, 2020 10:36
@Mic92
Copy link
Member Author

Mic92 commented Nov 19, 2020

Result of nixpkgs-review pr 104261 1

2 packages marked as broken and skipped:
  • python37Packages.qasm2image
  • python38Packages.qasm2image
2 packages failed to build:
  • gerbera
  • waybar
14 packages built:
  • bear
  • hal-hardware-analyzer
  • lizardfs
  • mtxclient
  • nheko
  • python37Packages.qiskit
  • python37Packages.qiskit-aer
  • python37Packages.qiskit-aqua
  • python37Packages.qiskit-ignis
  • python38Packages.qiskit
  • python38Packages.qiskit-aer
  • python38Packages.qiskit-aqua
  • python38Packages.qiskit-ignis
  • spdlog (spdlog_1)

@Mic92
Copy link
Member Author

Mic92 commented Nov 19, 2020

gerbera and waybar are not compatible with this version.

@Mic92
Copy link
Member Author

Mic92 commented Nov 19, 2020

@GrahamcOfBorg build gerbera waybar

@Mic92
Copy link
Member Author

Mic92 commented Nov 19, 2020

Here are the build logs:

waybar.log
gerbera.log

@Mic92
Copy link
Member Author

Mic92 commented Nov 19, 2020

@GrahamcOfBorg build gerbera waybar

@Mic92
Copy link
Member Author

Mic92 commented Nov 19, 2020

@GrahamcOfBorg eval

@Mic92 Mic92 merged commit 5e46d05 into NixOS:master Nov 20, 2020
@Mic92 Mic92 deleted the spdlog branch November 20, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant