Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass: separate dmenu from x11Support #104262

Merged
merged 1 commit into from Nov 25, 2020
Merged

pass: separate dmenu from x11Support #104262

merged 1 commit into from Nov 25, 2020

Conversation

Vonfry
Copy link
Member

@Vonfry Vonfry commented Nov 19, 2020 •
edited

Motivation for this change

#104249

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
ping maintaners

cc: @lovek323 @fpletz @tadfisher @globin @Ma27

@Vonfry Vonfry changed the title pass: seperate dmenu from x11Support pass: separate dmenu from x11Support Nov 19, 2020
@Vonfry
Copy link
Member Author

Vonfry commented Nov 20, 2020

nixpkgs-review:

10 packages built:
krunner-pass pass pass-nodmenu pass-otp pass-wayland passExtensions.pass-audit passExtensions.pass-import passff-host qtpass rofi-pass

@Vonfry Vonfry force-pushed the fix/pass branch 2 times, most recently from 4c09657 to 7789b60 Compare November 21, 2020 05:09
@Vonfry
Copy link
Member Author

Vonfry commented Nov 21, 2020

CI failed, but the problem seems to unrelate to this pr.

@Vonfry Vonfry requested a review from Ma27 November 21, 2020 05:24
@SuperSandro2000
Copy link
Member

CI failed, but the problem seems to unrelate to this pr.

Please rebase on master to fix the eval error.

@Vonfry
Copy link
Member Author

Vonfry commented Nov 25, 2020

I remove xdotool from x11Support as well, which is only needed by dmenu plugin.

@Ma27 Ma27 merged commit 6cd3c53 into NixOS:master Nov 25, 2020
@Ma27 Ma27 mentioned this pull request Nov 25, 2020
Closed
@Vonfry Vonfry deleted the fix/pass branch November 25, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

@tadfisher tadfisher Awaiting requested review from tadfisher

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Vonfry @SuperSandro2000 @Ma27