Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amdvlk: 2020.Q4.4 -> 2020.Q4.5 #104267

Merged
merged 1 commit into from Nov 22, 2020
Merged

amdvlk: 2020.Q4.4 -> 2020.Q4.5 #104267

merged 1 commit into from Nov 22, 2020

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Nov 19, 2020

Motivation for this change

2020.Q4.4 didn’t age well, here goes 2020.Q4.5 with RX 6800 support: https://github.com/GPUOpen-Drivers/AMDVLK/releases/tag/v-2020.Q4.5

Closure size compared to 2020.Q4.3 (which I still have installed):
/nix/store/nbvkmav524q20z0j1gm49xkda3yzl54d-amdvlk-2020.Q4.3 103230952 (~98.4 MiB)
/nix/store/da87cbkih1r856b96x3il2mgq9kkgym7-amdvlk-2020.Q4.5 104152552 (~99.3 MiB)

i686 version
/nix/store/64xxlxvy64fm59x96s6nka1xslxidp62-amdvlk-2020.Q4.3 108721400 (~103.7 MiB)
/nix/store/ziiyvi9xvl06yxdyh3xjh02fvqq4yvyr-amdvlk-2020.Q4.5 109737208 (~104.7 MiB)

Things done
  • Tested vkcube and Dota 2
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zowoq
Copy link
Contributor

zowoq commented Nov 19, 2020

@ofborg eval

@ofborg ofborg bot requested a review from danieldk November 19, 2020 14:14
danieldk
danieldk approved these changes Nov 22, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 104267 1

2 packages built:
  • amdvlk
  • driversi686Linux.amdvlk

@danieldk danieldk merged commit b653e00 into NixOS:master Nov 22, 2020
@Flakebi Flakebi deleted the amdvlk branch November 22, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Flakebi @zowoq @danieldk