Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wordgrinder: 0.7.2 -> 0.8 #104882

Closed
wants to merge 1 commit into from
Closed

wordgrinder: 0.7.2 -> 0.8 #104882

wants to merge 1 commit into from

Conversation

matthiasbeyer
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthiasbeyer
wordgrinder: 0.7.2 -> 0.8
d8acd07 
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@lukegb
Copy link
Contributor

lukegb commented Nov 25, 2020

Result of nixpkgs-review pr 104882 1

1 package built:
  • wordgrinder

lukegb
lukegb approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@lukegb lukegb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and ran wordgrinder and typed a few words, LGTM.

image

@Luflosi
Copy link
Contributor

Luflosi commented Nov 25, 2020

This was already merged in #101539.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukegb lukegb lukegb approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiasbeyer @lukegb @Luflosi